net/socket/ssl_client_socket_impl.h - Issue 2623803002: Avoid creating MemoryAllocatorDump for individual sockets

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/ssl_client_socket_impl.h

Issue 2623803002: Avoid creating MemoryAllocatorDump for individual sockets (Closed)

Patch Set: Address Eric's comments Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/socket/ssl_client_socket_impl.h

diff --git a/net/socket/ssl_client_socket_impl.h b/net/socket/ssl_client_socket_impl.h

index 4d44008cd7ff4e7090861b8f85547c9a95447311..d010852fd810bcec06fbc2e591d61632379b1da5 100644

--- a/net/socket/ssl_client_socket_impl.h

+++ b/net/socket/ssl_client_socket_impl.h

@@ -117,9 +117,7 @@ class SSLClientSocketImpl : public SSLClientSocket,

void ClearConnectionAttempts() override {}

void AddConnectionAttempts(const ConnectionAttempts& attempts) override {}

int64_t GetTotalReceivedBytes() const override;

- void DumpMemoryStats(

- base::trace_event::ProcessMemoryDump* pmd,

- const std::string& parent_dump_absolute_name) const override;

+ void DumpMemoryStats(SocketMemoryStats* stats) const override;

// Dumps memory allocation stats. |pmd| is the browser process memory dump.

static void DumpSSLClientSessionMemoryStats(

« no previous file with comments | « net/socket/client_socket_pool_base.cc ('k') | net/socket/ssl_client_socket_impl.cc » ('j') | no next file with comments »