net/socket/client_socket_handle.cc - Issue 2623803002: Avoid creating MemoryAllocatorDump for individual sockets

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/client_socket_handle.cc

Issue 2623803002: Avoid creating MemoryAllocatorDump for individual sockets (Closed)

Patch Set: Address Eric's comments Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/socket/client_socket_handle.cc

diff --git a/net/socket/client_socket_handle.cc b/net/socket/client_socket_handle.cc

index be58c7296d62c1b763888f0392edb43174f1a931..983efa7c83ca5cc920445106dbecc41e94eb669a 100644

--- a/net/socket/client_socket_handle.cc

+++ b/net/socket/client_socket_handle.cc

@@ -134,9 +134,8 @@ bool ClientSocketHandle::GetLoadTimingInfo(

}

void ClientSocketHandle::DumpMemoryStats(

- base::trace_event::ProcessMemoryDump* pmd,

- const std::string& parent_absolute_name) const {

- socket_->DumpMemoryStats(pmd, parent_absolute_name);

+ StreamSocket::SocketMemoryStats* stats) const {

+ socket_->DumpMemoryStats(stats);

}

void ClientSocketHandle::SetSocket(std::unique_ptr<StreamSocket> s) {

« no previous file with comments | « net/socket/client_socket_handle.h ('k') | net/socket/client_socket_pool_base.cc » ('j') | no next file with comments »