Avoid creating MemoryAllocatorDump for individual sockets

net/socket/stream_socket.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_SOCKET_STREAM_SOCKET_H_
 #define NET_SOCKET_STREAM_SOCKET_H_
 
 #include <stdint.h>
 
 #include "base/macros.h"
 #include "net/base/net_export.h"
 #include "net/socket/connection_attempts.h"
 #include "net/socket/next_proto.h"
 #include "net/socket/socket.h"
 
-namespace base {
-namespace trace_event {
-class ProcessMemoryDump;
-}
-}
-
 namespace net {
 
 class IPEndPoint;
 class NetLogWithSource;
 class SSLInfo;
 
 class NET_EXPORT_PRIVATE StreamSocket : public Socket {
  public:
+  // This is used in DumpMemoryStats() to track the estimate of memory usage of
+  // a socket.
+  struct NET_EXPORT_PRIVATE SocketMemoryStats {
+   public:
+    SocketMemoryStats();
+    ~SocketMemoryStats();
+    // Estimated total memory usage of this socket in bytes.
+    size_t total_size;
+    // Size of all buffers used by this socket in bytes.
+    size_t buffer_size;
+    // Number of certs used by this socket.
+    size_t cert_count;
+    // Total size of certs used by this socket in bytes.
+    size_t serialized_cert_size;
+
+   private:
+    DISALLOW_COPY_AND_ASSIGN(SocketMemoryStats);
+  };
+
   ~StreamSocket() override {}
 
   // Called to establish a connection.  Returns OK if the connection could be
   // established synchronously.  Otherwise, ERR_IO_PENDING is returned and the
   // given callback will run asynchronously when the connection is established
   // or when an error occurs.  The result is some other error code if the
   // connection could not be established.
   //
   // The socket's Read and Write methods may not be called until Connect
   // succeeds.
@@ skipping 69 matching lines @@
 
   // Adds |attempts| to the socket's list of connection attempts.
   virtual void AddConnectionAttempts(const ConnectionAttempts& attempts) = 0;
 
   // Returns the total number of number bytes read by the socket. This only
   // counts the payload bytes. Transport headers are not counted. Returns
   // 0 if the socket does not implement the function. The count is reset when
   // Disconnect() is called.
   virtual int64_t GetTotalReceivedBytes() const = 0;
 
-  // Dumps memory allocation stats. |parent_dump_absolute_name| is the name
-  // used by the parent MemoryAllocatorDump in the memory dump hierarchy.
-  // Default implementation does nothing.
-  virtual void DumpMemoryStats(
-      base::trace_event::ProcessMemoryDump* pmd,
-      const std::string& parent_dump_absolute_name) const {};
+  // Dumps memory allocation stats into |stats|. |stats| can be assumed as being
+  // default initialized upon entry. Implementations should override fields in
+  // |stats| and not increment them. Default implementation does nothing.

[eroman, 2017/01/11 22:15:14]

nit: can omit the phrasing about "not increment them". If it is default
initialized, then incrementing has the same effect as overwriting (assuming you
start at 0).

[xunjieli, 2017/01/11 23:19:24]

Done.

+  virtual void DumpMemoryStats(SocketMemoryStats* stats) const {}
 
  protected:
   // The following class is only used to gather statistics about the history of
   // a socket.  It is only instantiated and used in basic sockets, such as
   // TCPClientSocket* instances.  Other classes that are derived from
   // StreamSocket should forward any potential settings to their underlying
   // transport sockets.
   class UseHistory {
    public:
     UseHistory();
@@ skipping 27 matching lines @@
     // identify the motivation.
     bool omnibox_speculation_;
     bool subresource_speculation_;
     DISALLOW_COPY_AND_ASSIGN(UseHistory);
   };
 };
 
 }  // namespace net
 
 #endif  // NET_SOCKET_STREAM_SOCKET_H_