Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Unified Diff: ui/views/controls/separator.h

Issue 2623753002: Native themes: Add separator color (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/controls/separator.h
diff --git a/ui/views/controls/separator.h b/ui/views/controls/separator.h
index 45e23b3a7daaca6675d0bb425964f0b0b07e3a52..d4689fe209748b9241bebf63b616d9227a4ccf91 100644
--- a/ui/views/controls/separator.h
+++ b/ui/views/controls/separator.h
@@ -40,11 +40,15 @@ class VIEWS_EXPORT Separator : public View {
gfx::Size GetPreferredSize() const override;
void GetAccessibleNodeData(ui::AXNodeData* node_data) override;
void OnPaint(gfx::Canvas* canvas) override;
+ void OnNativeThemeChanged(const ui::NativeTheme* theme) override;
const char* GetClassName() const override;
private:
+ void SetColorFromNativeTheme();
+
const Orientation orientation_;
SkColor color_;
Evan Stade 2017/01/10 16:58:07 if you make this base::Optional<SkColor> you don't
Tom (Use chromium acct) 2017/01/10 20:59:10 But then color() would be more complicated and it
Evan Stade 2017/01/11 00:32:04 good thing it's never actually called then
+ bool color_overridden_;
int size_;
DISALLOW_COPY_AND_ASSIGN(Separator);

Powered by Google App Engine
This is Rietveld 408576698