Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Unified Diff: tools/foozzie/v8_foozzie.py

Issue 2623743004: [foozzie] Pass startup test (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/foozzie/v8_foozzie.py
diff --git a/tools/foozzie/v8_foozzie.py b/tools/foozzie/v8_foozzie.py
index df4c0785a791e0085f2218ff23956928141569f7..4581d2039fa74aadda484bcc0111acc9437684fe 100755
--- a/tools/foozzie/v8_foozzie.py
+++ b/tools/foozzie/v8_foozzie.py
@@ -101,9 +101,13 @@ def parse_args():
parser.add_argument(
'--second-d8',
help='optional path to second d8 executable, default: same as first')
- parser.add_argument('testcase', help='path to test case')
+ parser.add_argument('testcase', help='path to test case', nargs='?')
options = parser.parse_args()
+ if not options.testcase:
+ # Don't check further as we want to bail out early without test case.
+ return options
+
# Ensure we make a sane comparison.
assert (options.first_arch != options.second_arch or
options.first_config != options.second_config) , (
@@ -185,6 +189,10 @@ def fail_bailout(output, ignore_by_output_fun):
def main():
options = parse_args()
+ if not options.testcase:
+ print '# V8 correctness - pass - no test file given'
+ return RETURN_PASS
+
# Suppressions are architecture and configuration specific.
suppress = v8_suppressions.get_suppression(
options.first_arch, options.first_config,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698