third_party/WebKit/Source/devtools/front_end/profiler/ProfileDataGrid.js - Issue 2623743002: DevTools: extract modules (non-extensions)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/profiler/ProfileDataGrid.js

Issue 2623743002: DevTools: extract modules (non-extensions) (Closed)

Patch Set: rebaseline Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/components_lazy/module.json ('K') | « third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotView.js ('k') | third_party/WebKit/Source/devtools/front_end/profiler/ProfileView.js » ('j') | third_party/WebKit/Source/devtools/front_end/sdk/module.json » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/profiler/ProfileDataGrid.js

diff --git a/third_party/WebKit/Source/devtools/front_end/profiler/ProfileDataGrid.js b/third_party/WebKit/Source/devtools/front_end/profiler/ProfileDataGrid.js

index bd6cb3fabdfb53542c3bd6a8a97f741bc4366b99..434fcef82e35c54b737f53d79bf2f8e94a9720e6 100644

--- a/third_party/WebKit/Source/devtools/front_end/profiler/ProfileDataGrid.js

+++ b/third_party/WebKit/Source/devtools/front_end/profiler/ProfileDataGrid.js

@@ -26,7 +26,7 @@

/**

* @unrestricted

-Profiler.ProfileDataGridNode = class extends UI.DataGridNode {

+Profiler.ProfileDataGridNode = class extends DataGrid.DataGridNode {

/**

* @param {!SDK.ProfileNode} profileNode

* @param {!Profiler.ProfileDataGridTree} owningTree

@@ -208,7 +208,7 @@ Profiler.ProfileDataGridNode = class extends UI.DataGridNode {

/**

* @override

- * @param {!UI.DataGridNode} profileDataGridNode

+ * @param {!DataGrid.DataGridNode} profileDataGridNode

* @param {number} index

insertChild(profileDataGridNode, index) {

@@ -220,7 +220,7 @@ Profiler.ProfileDataGridNode = class extends UI.DataGridNode {

/**

* @override

- * @param {!UI.DataGridNode} profileDataGridNode

+ * @param {!DataGrid.DataGridNode} profileDataGridNode

removeChild(profileDataGridNode) {

super.removeChild(profileDataGridNode);