third_party/WebKit/Source/devtools/front_end/perf_ui/ChartViewport.js - Issue 2623743002: DevTools: extract modules (non-extensions)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/perf_ui/ChartViewport.js

Issue 2623743002: DevTools: extract modules (non-extensions) (Closed)

Patch Set: rebaseline Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/components_lazy/module.json ('K') | « third_party/WebKit/Source/devtools/front_end/network/module.json ('k') | third_party/WebKit/Source/devtools/front_end/perf_ui/FilmStripView.js » ('j') | third_party/WebKit/Source/devtools/front_end/sdk/module.json » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/perf_ui/ChartViewport.js

diff --git a/third_party/WebKit/Source/devtools/front_end/ui_lazy/ChartViewport.js b/third_party/WebKit/Source/devtools/front_end/perf_ui/ChartViewport.js

similarity index 99%

rename from third_party/WebKit/Source/devtools/front_end/ui_lazy/ChartViewport.js

rename to third_party/WebKit/Source/devtools/front_end/perf_ui/ChartViewport.js

index 32ee51c15af8c7e91a7a07f7f34199713a697585..ede93ece84025b44000db61b395e56480ac93c41 100644

--- a/third_party/WebKit/Source/devtools/front_end/ui_lazy/ChartViewport.js

+++ b/third_party/WebKit/Source/devtools/front_end/perf_ui/ChartViewport.js

@@ -4,7 +4,7 @@

/**

* @unrestricted

-UI.ChartViewport = class extends UI.VBox {

+PerfUI.ChartViewport = class extends UI.VBox {

constructor() {

super(true);

@@ -371,7 +371,7 @@ UI.ChartViewport = class extends UI.VBox {

_requestWindowTimes(bounds) {

bounds.left = Number.constrain(bounds.left, this._minimumBoundary, this._totalTime + this._minimumBoundary);

bounds.right = Number.constrain(bounds.right, this._minimumBoundary, this._totalTime + this._minimumBoundary);

- if (bounds.right - bounds.left < UI.FlameChart.MinimalTimeWindowMs)

+ if (bounds.right - bounds.left < PerfUI.FlameChart.MinimalTimeWindowMs)

return;

this._flameChartDelegate.requestWindowTimes(bounds.left, bounds.right);

}