Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(652)

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js

Issue 2623743002: DevTools: extract modules (non-extensions) (Closed)
Patch Set: rebaseline Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js b/third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js
index c0f3254a95a69e6eea37d0510f29080326355474..ef4fa693f1a27189b19b876b5dc2690afe31efe0 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js
@@ -32,13 +32,18 @@ Network.ResourceWebSocketFrameView = class extends UI.VBox {
this._splitWidget = new UI.SplitWidget(false, true, 'resourceWebSocketFrameSplitViewState');
this._splitWidget.show(this.element);
- var columns = /** @type {!Array<!UI.DataGrid.ColumnDescriptor>} */ ([
- {id: 'data', title: Common.UIString('Data'), sortable: false, weight: 88},
- {id: 'length', title: Common.UIString('Length'), sortable: false, align: UI.DataGrid.Align.Right, weight: 5},
+ var columns = /** @type {!Array<!DataGrid.DataGrid.ColumnDescriptor>} */ ([
+ {id: 'data', title: Common.UIString('Data'), sortable: false, weight: 88}, {
+ id: 'length',
+ title: Common.UIString('Length'),
+ sortable: false,
+ align: DataGrid.DataGrid.Align.Right,
+ weight: 5
+ },
{id: 'time', title: Common.UIString('Time'), sortable: true, weight: 7}
]);
- this._dataGrid = new UI.SortableDataGrid(columns);
+ this._dataGrid = new DataGrid.SortableDataGrid(columns);
this._dataGrid.setRowContextMenuCallback(onRowContextMenu);
this._dataGrid.setStickToBottom(true);
this._dataGrid.setCellClass('websocket-frame-view-td');
@@ -46,12 +51,12 @@ Network.ResourceWebSocketFrameView = class extends UI.VBox {
/** @type {function(!Network.ResourceWebSocketFrameNode, !Network.ResourceWebSocketFrameNode):number} */ (
Network.ResourceWebSocketFrameNodeTimeComparator);
this._dataGrid.sortNodes(this._timeComparator, false);
- this._dataGrid.markColumnAsSortedBy('time', UI.DataGrid.Order.Ascending);
- this._dataGrid.addEventListener(UI.DataGrid.Events.SortingChanged, this._sortItems, this);
+ this._dataGrid.markColumnAsSortedBy('time', DataGrid.DataGrid.Order.Ascending);
+ this._dataGrid.addEventListener(DataGrid.DataGrid.Events.SortingChanged, this._sortItems, this);
this._dataGrid.setName('ResourceWebSocketFrameView');
- this._dataGrid.addEventListener(UI.DataGrid.Events.SelectedNode, this._onFrameSelected, this);
- this._dataGrid.addEventListener(UI.DataGrid.Events.DeselectedNode, this._onFrameDeselected, this);
+ this._dataGrid.addEventListener(DataGrid.DataGrid.Events.SelectedNode, this._onFrameSelected, this);
+ this._dataGrid.addEventListener(DataGrid.DataGrid.Events.DeselectedNode, this._onFrameDeselected, this);
this._splitWidget.setMainWidget(this._dataGrid.asWidget());
var view = new UI.EmptyWidget('Select frame to browse its content.');
@@ -62,7 +67,7 @@ Network.ResourceWebSocketFrameView = class extends UI.VBox {
/**
* @param {!UI.ContextMenu} contextMenu
- * @param {!UI.DataGridNode} node
+ * @param {!DataGrid.DataGridNode} node
*/
function onRowContextMenu(contextMenu, node) {
contextMenu.appendItem(
@@ -184,7 +189,7 @@ Network.ResourceWebSocketFrameView.opCodeDescriptions = (function() {
/**
* @unrestricted
*/
-Network.ResourceWebSocketFrameNode = class extends UI.SortableDataGridNode {
+Network.ResourceWebSocketFrameNode = class extends DataGrid.SortableDataGridNode {
/**
* @param {string} url
* @param {!SDK.NetworkRequest.WebSocketFrame} frame

Powered by Google App Engine
This is Rietveld 408576698