third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js - Issue 2623743002: DevTools: extract modules (non-extensions)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

Issue 2623743002: DevTools: extract modules (non-extensions) (Closed)

Patch Set: rebaseline Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js ('k') | third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

index 61744513eff92ca4468d9f660fd033519d5c19c1..3993ab6f0856941987e2844f6d787bdb62c9cac5 100644

--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

@@ -522,7 +522,7 @@ Network.NetworkLogView = class extends UI.VBox {

}

_setupDataGrid() {

- /** @type {!UI.SortableDataGrid<!Network.NetworkNode>} */

+ /** @type {!DataGrid.SortableDataGrid<!Network.NetworkNode>} */

this._dataGrid = this._columns.dataGrid();

this._dataGrid.setRowContextMenuCallback((contextMenu, node) => {

var request = node.request();

@@ -531,7 +531,7 @@ Network.NetworkLogView = class extends UI.VBox {

});

this._dataGrid.setStickToBottom(true);

this._dataGrid.setName('networkLog');

- this._dataGrid.setResizeMethod(UI.DataGrid.ResizeMethod.Last);

+ this._dataGrid.setResizeMethod(DataGrid.DataGrid.ResizeMethod.Last);

this._dataGrid.element.classList.add('network-log-grid');

this._dataGrid.element.addEventListener('mousedown', this._dataGridMouseDown.bind(this), true);

this._dataGrid.element.addEventListener('mousemove', this._dataGridMouseMove.bind(this), true);