Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js

Issue 2623743002: DevTools: extract modules (non-extensions) (Closed)
Patch Set: rebaseline Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 .createChild('div', 'settings-window-title') 45 .createChild('div', 'settings-window-title')
46 .textContent = Common.UIString('Settings'); 46 .textContent = Common.UIString('Settings');
47 47
48 this._tabbedLocation = 48 this._tabbedLocation =
49 UI.viewManager.createTabbedLocation(() => Settings.SettingsScreen._showS ettingsScreen(), 'settings-view'); 49 UI.viewManager.createTabbedLocation(() => Settings.SettingsScreen._showS ettingsScreen(), 'settings-view');
50 var tabbedPane = this._tabbedLocation.tabbedPane(); 50 var tabbedPane = this._tabbedLocation.tabbedPane();
51 tabbedPane.leftToolbar().appendToolbarItem(new UI.ToolbarItem(settingsLabelE lement)); 51 tabbedPane.leftToolbar().appendToolbarItem(new UI.ToolbarItem(settingsLabelE lement));
52 tabbedPane.setShrinkableTabs(false); 52 tabbedPane.setShrinkableTabs(false);
53 tabbedPane.setVerticalTabLayout(true); 53 tabbedPane.setVerticalTabLayout(true);
54 var shortcutsView = new UI.SimpleView(Common.UIString('Shortcuts')); 54 var shortcutsView = new UI.SimpleView(Common.UIString('Shortcuts'));
55 Components.shortcutsScreen.createShortcutsTabView().show(shortcutsView.eleme nt); 55 UI.shortcutsScreen.createShortcutsTabView().show(shortcutsView.element);
56 this._tabbedLocation.appendView(shortcutsView); 56 this._tabbedLocation.appendView(shortcutsView);
57 tabbedPane.show(this.contentElement); 57 tabbedPane.show(this.contentElement);
58 58
59 this.element.addEventListener('keydown', this._keyDown.bind(this), false); 59 this.element.addEventListener('keydown', this._keyDown.bind(this), false);
60 this._developerModeCounter = 0; 60 this._developerModeCounter = 0;
61 this.setDefaultFocusedElement(this.contentElement); 61 this.setDefaultFocusedElement(this.contentElement);
62 } 62 }
63 63
64 /** 64 /**
65 * @param {string=} name 65 * @param {string=} name
(...skipping 479 matching lines...) Expand 10 before | Expand all | Expand 10 after
545 return; 545 return;
546 var settings = extension.descriptor()['settings']; 546 var settings = extension.descriptor()['settings'];
547 if (settings && settings.indexOf(setting.name) !== -1) { 547 if (settings && settings.indexOf(setting.name) !== -1) {
548 InspectorFrontendHost.bringToFront(); 548 InspectorFrontendHost.bringToFront();
549 Settings.SettingsScreen._showSettingsScreen(extension.descriptor()['id'] ); 549 Settings.SettingsScreen._showSettingsScreen(extension.descriptor()['id'] );
550 success = true; 550 success = true;
551 } 551 }
552 } 552 }
553 } 553 }
554 }; 554 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698