Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3769)

Unified Diff: chrome/browser/safe_browsing/ui_manager_unittest.cc

Issue 2623733002: Componentize SafeBrowsingBlockingPage for WebView use (Closed)
Patch Set: address final comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/safe_browsing/ui_manager.cc ('k') | components/safe_browsing/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/safe_browsing/ui_manager_unittest.cc
diff --git a/chrome/browser/safe_browsing/ui_manager_unittest.cc b/chrome/browser/safe_browsing/ui_manager_unittest.cc
index 31d4ebc8a3bdcd739eefa1b328aab4e947d310df..30b7cf820571cdd9036c23dc383b07e335bfea36 100644
--- a/chrome/browser/safe_browsing/ui_manager_unittest.cc
+++ b/chrome/browser/safe_browsing/ui_manager_unittest.cc
@@ -334,14 +334,16 @@ class SecurityStateWebContentsDelegate : public content::WebContentsDelegate {
// A test blocking page that does not create windows.
class TestSafeBrowsingBlockingPage : public SafeBrowsingBlockingPage {
public:
- TestSafeBrowsingBlockingPage(SafeBrowsingUIManager* manager,
+ TestSafeBrowsingBlockingPage(BaseUIManager* manager,
content::WebContents* web_contents,
const GURL& main_frame_url,
const UnsafeResourceList& unsafe_resources)
- : SafeBrowsingBlockingPage(manager,
- web_contents,
- main_frame_url,
- unsafe_resources) {
+ : SafeBrowsingBlockingPage(
+ manager,
+ web_contents,
+ main_frame_url,
+ unsafe_resources,
+ BaseBlockingPage::CreateDefaultDisplayOptions(unsafe_resources)) {
// Don't delay details at all for the unittest.
threat_details_proceed_delay_ms_ = 0;
DontCreateViewForTesting();
@@ -356,7 +358,7 @@ class TestSafeBrowsingBlockingPageFactory
~TestSafeBrowsingBlockingPageFactory() override {}
SafeBrowsingBlockingPage* CreateSafeBrowsingPage(
- SafeBrowsingUIManager* delegate,
+ BaseUIManager* delegate,
content::WebContents* web_contents,
const GURL& main_frame_url,
const SafeBrowsingBlockingPage::UnsafeResourceList& unsafe_resources)
« no previous file with comments | « chrome/browser/safe_browsing/ui_manager.cc ('k') | components/safe_browsing/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698