Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Unified Diff: chrome/browser/safe_browsing/ui_manager_unittest.cc

Issue 2623733002: Componentize SafeBrowsingBlockingPage for WebView use (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/ui_manager_unittest.cc
diff --git a/chrome/browser/safe_browsing/ui_manager_unittest.cc b/chrome/browser/safe_browsing/ui_manager_unittest.cc
index 31d4ebc8a3bdcd739eefa1b328aab4e947d310df..ece63be7238b974caebe16b11ba14a594bd968d1 100644
--- a/chrome/browser/safe_browsing/ui_manager_unittest.cc
+++ b/chrome/browser/safe_browsing/ui_manager_unittest.cc
@@ -334,14 +334,15 @@ class SecurityStateWebContentsDelegate : public content::WebContentsDelegate {
// A test blocking page that does not create windows.
class TestSafeBrowsingBlockingPage : public SafeBrowsingBlockingPage {
public:
- TestSafeBrowsingBlockingPage(SafeBrowsingUIManager* manager,
+ TestSafeBrowsingBlockingPage(BaseSafeBrowsingUIManager* manager,
content::WebContents* web_contents,
const GURL& main_frame_url,
const UnsafeResourceList& unsafe_resources)
: SafeBrowsingBlockingPage(manager,
web_contents,
main_frame_url,
- unsafe_resources) {
+ unsafe_resources,
+ nullptr) {
// Don't delay details at all for the unittest.
threat_details_proceed_delay_ms_ = 0;
DontCreateViewForTesting();
@@ -356,7 +357,7 @@ class TestSafeBrowsingBlockingPageFactory
~TestSafeBrowsingBlockingPageFactory() override {}
SafeBrowsingBlockingPage* CreateSafeBrowsingPage(
- SafeBrowsingUIManager* delegate,
+ BaseSafeBrowsingUIManager* delegate,
content::WebContents* web_contents,
const GURL& main_frame_url,
const SafeBrowsingBlockingPage::UnsafeResourceList& unsafe_resources)

Powered by Google App Engine
This is Rietveld 408576698