Componentize SafeBrowsingBlockingPage for WebView use

chrome/browser/safe_browsing/ui_manager.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // The Safe Browsing service is responsible for downloading anti-phishing and
 // anti-malware tables and checking urls against them.
 
 #ifndef CHROME_BROWSER_SAFE_BROWSING_UI_MANAGER_H_
 #define CHROME_BROWSER_SAFE_BROWSING_UI_MANAGER_H_
 
 #include <string>
 #include <vector>
 
 #include "base/callback.h"
 #include "base/macros.h"
+#include "base/observer_list.h"
 #include "base/time/time.h"
 #include "chrome/browser/permissions/permission_uma_util.h"
 #include "chrome/browser/safe_browsing/safe_browsing_service.h"
 #include "components/safe_browsing/base_ui_manager.h"
 
 class GURL;
 
 namespace content {
 class WebContents;
 struct PermissionReportInfo;
 }  // namespace content
 
+namespace history {
+class HistoryService;
+}  // namespace history
+
 namespace safe_browsing {
 
 struct HitReport;
 
 // Construction needs to happen on the main thread.
-class SafeBrowsingUIManager : public BaseSafeBrowsingUIManager {
+class SafeBrowsingUIManager : public BaseUIManager {
  public:
+  // Observer class can be used to get notified when a SafeBrowsing hit
+  // was found.

[meacer, 2017/01/11 01:33:30]

nit: was -> is

[Jialiu Lin, 2017/01/11 02:53:15]

Done.

+  class Observer {
+   public:
+    // The |resource| was classified as unsafe by SafeBrowsing, and is
+    // not whitelisted.

[meacer, 2017/01/11 01:33:30]

nit: maybe say "Called when |resource| is classified as unsafe ..."?

[Jialiu Lin, 2017/01/11 02:53:15]

Done.

+    // The |resource| must not be accessed after OnSafeBrowsingHit returns.
+    // This method will be called on the UI thread.
+    virtual void OnSafeBrowsingHit(const UnsafeResource& resource) = 0;
+
+   protected:
+    Observer() {}
+    virtual ~Observer() {}
+
+   private:
+    DISALLOW_COPY_AND_ASSIGN(Observer);
+  };
+
   explicit SafeBrowsingUIManager(
       const scoped_refptr<SafeBrowsingService>& service);
 
   // Called to stop or shutdown operations on the io_thread. This may be called
   // multiple times during the life of the UIManager. Should be called
   // on IO thread. If shutdown is true, the manager is disabled permanently.
   void StopOnIOThread(bool shutdown) override;
 
   // Called on the UI thread to display an interstitial page.
   // |url| is the url of the resource that matches a safe browsing list.
   // If the request contained a chain of redirects, |url| is the last url
   // in the chain, and |original_url| is the first one (the root of the
   // chain). Otherwise, |original_url| = |url|.
   void DisplayBlockingPage(const UnsafeResource& resource) override;
 
-  // Log the user perceived delay caused by SafeBrowsing. This delay is the time
-  // delta starting from when we would have started reading data from the
-  // network, and ending when the SafeBrowsing check completes indicating that
-  // the current page is 'safe'.
-  void LogPauseDelay(base::TimeDelta time) override;
-
   // Called on the IO thread by the ThreatDetails with the serialized
   // protocol buffer, so the service can send it over.
   void SendSerializedThreatDetails(const std::string& serialized) override;
 
   // Report hits to the unsafe contents (malware, phishing, unsafe download URL)
   // to the server. Can only be called on UI thread.  If |post_data| is
   // non-empty, the request will be sent as a POST instead of a GET.
   // Will report only for UMA || is_extended_reporting.
   void MaybeReportSafeBrowsingHit(
       const safe_browsing::HitReport& hit_report) override;
 
   // Report permission action to SafeBrowsing servers. Can only be called on UI
   // thread.
   void ReportPermissionAction(const PermissionReportInfo& report_info);
 
   // Creates the whitelist URL set for tests that create a blocking page
   // themselves and then simulate OnBlockingPageDone(). OnBlockingPageDone()
   // expects the whitelist to exist, but the tests don't necessarily call
   // DisplayBlockingPage(), which creates it.
   static void CreateWhitelistForTesting(content::WebContents* web_contents);
 
+  // Add and remove observers.  These methods must be invoked on the UI thread.

[meacer, 2017/01/11 01:33:30]

tiny nit: Single space after the period.

[Jialiu Lin, 2017/01/11 02:53:15]

Good eye! Done.

+  void AddObserver(Observer* observer);
+  void RemoveObserver(Observer* remove);
+
+  const std::string app_locale() const override;
+  history::HistoryService* history_service(
+      content::WebContents* web_contents) override;
+  const GURL default_safe_page() const override;
+
  protected:
   ~SafeBrowsingUIManager() override;
 
   // Call protocol manager on IO thread to report hits of unsafe contents.
   void ReportSafeBrowsingHitOnIOThread(
       const safe_browsing::HitReport& hit_report) override;
 
  private:
   friend class SafeBrowsingUIManagerTest;
   friend class TestSafeBrowsingUIManager;
 
   // Report permission action to SafeBrowsing servers.
   void ReportPermissionActionOnIOThread(
       const PermissionReportInfo& report_info);
 
   static GURL GetMainFrameWhitelistUrlForResourceForTesting(
       const safe_browsing::SafeBrowsingUIManager::UnsafeResource& resource);
 
   // Safebrowsing service.
   scoped_refptr<SafeBrowsingService> sb_service_;
 
+  base::ObserverList<Observer> observer_list_;
+
   DISALLOW_COPY_AND_ASSIGN(SafeBrowsingUIManager);
 };
 
 }  // namespace safe_browsing
 
 #endif  // CHROME_BROWSER_SAFE_BROWSING_UI_MANAGER_H_