Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(722)

Unified Diff: components/sync/model/model_type_store.h

Issue 2623723002: [Sync] Remove ModelError::IsSet() in favor of base::Optional. (Closed)
Patch Set: Rebase. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync/model/model_type_store.h
diff --git a/components/sync/model/model_type_store.h b/components/sync/model/model_type_store.h
index dd361f390e8ae4b5d060702dc28dad5abf516b7d..d640c9eb5d78ac6032ff05173b33a0524748aa82 100644
--- a/components/sync/model/model_type_store.h
+++ b/components/sync/model/model_type_store.h
@@ -11,6 +11,7 @@
#include "base/callback.h"
#include "base/macros.h"
+#include "base/optional.h"
#include "components/sync/base/model_type.h"
#include "components/sync/model/metadata_batch.h"
#include "components/sync/model/metadata_change_list.h"
@@ -119,7 +120,7 @@ class ModelTypeStore {
typedef base::Callback<void(Result result,
std::unique_ptr<RecordList> data_records)>
ReadAllDataCallback;
- typedef base::Callback<void(ModelError error,
+ typedef base::Callback<void(base::Optional<ModelError> error,
std::unique_ptr<MetadataBatch> metadata_batch)>
ReadMetadataCallback;

Powered by Google App Engine
This is Rietveld 408576698