components/sync/driver/model_type_controller.cc - Issue 2623723002: [Sync] Remove ModelError::IsSet() in favor of base::Optional.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync/driver/model_type_controller.cc

Issue 2623723002: [Sync] Remove ModelError::IsSet() in favor of base::Optional. (Closed)

Patch Set: Rebase. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/sync/driver/model_type_controller.cc

diff --git a/components/sync/driver/model_type_controller.cc b/components/sync/driver/model_type_controller.cc

index 09a65fb6b2fb62f0cab3c58891f2f3a711c713ef..b0d28cf087cf72346d312fa894b5625b02ed746e 100644

--- a/components/sync/driver/model_type_controller.cc

+++ b/components/sync/driver/model_type_controller.cc

@@ -255,7 +255,6 @@ DataTypeController::State ModelTypeController::state() const {

void ModelTypeController::ReportModelError(const ModelError& error) {

DCHECK(CalledOnValidThread());

- DCHECK(error.IsSet());

LoadModelsDone(UNRECOVERABLE_ERROR,

SyncError(error.location(), SyncError::DATATYPE_ERROR,

error.message(), type()));