Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 26237010: remove clipstack/region bounds assertion (Closed)

Created:
7 years, 2 months ago by bsalomon
Modified:
7 years, 2 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

remove clipstack/region bounds assertion BUG=skia_1720 Committed: http://code.google.com/p/skia/source/detail?r=11772

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -36 lines) Patch
M src/gpu/SkGpuDevice.cpp View 2 chunks +0 lines, -36 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
bsalomon
I wasn't sure about the change you suggested related a parameter to the function.
7 years, 2 months ago (2013-10-15 14:29:42 UTC) #1
robertphillips
lgtm. I had misremembered. Since the region is embedded in the draw we can't avoid ...
7 years, 2 months ago (2013-10-15 15:02:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/26237010/1
7 years, 2 months ago (2013-10-15 15:05:03 UTC) #3
commit-bot: I haz the power
7 years, 2 months ago (2013-10-15 15:14:44 UTC) #4
Message was sent while issue was closed. 
Change committed as 11772

Powered by Google App Engine
This is Rietveld 408576698