Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Unified Diff: Source/web/EditorClientImpl.cpp

Issue 26237004: Remove unused editing related member functions from WebViewClient (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: 2013-10-09T17:59:14 Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/EditorClientImpl.h ('k') | Source/web/WebFrameImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/EditorClientImpl.cpp
diff --git a/Source/web/EditorClientImpl.cpp b/Source/web/EditorClientImpl.cpp
index 567adae6bb867522ce141780d1115f071a155509..d68909331e1b98713af3697fde565e74b6bc7833 100644
--- a/Source/web/EditorClientImpl.cpp
+++ b/Source/web/EditorClientImpl.cpp
@@ -164,81 +164,6 @@ bool EditorClientImpl::isGrammarCheckingEnabled()
return frame && frame->settings() && (frame->settings()->asynchronousSpellCheckingEnabled() || frame->settings()->unifiedTextCheckerEnabled());
}
-bool EditorClientImpl::shouldBeginEditing(Range* range)
-{
- if (m_webView->client())
- return m_webView->client()->shouldBeginEditing(WebRange(range));
- return true;
-}
-
-bool EditorClientImpl::shouldEndEditing(Range* range)
-{
- if (m_webView->client())
- return m_webView->client()->shouldEndEditing(WebRange(range));
- return true;
-}
-
-bool EditorClientImpl::shouldInsertNode(Node* node,
- Range* range,
- EditorInsertAction action)
-{
- if (m_webView->client()) {
- return m_webView->client()->shouldInsertNode(WebNode(node),
- WebRange(range),
- static_cast<WebEditingAction>(action));
- }
- return true;
-}
-
-bool EditorClientImpl::shouldInsertText(const String& text,
- Range* range,
- EditorInsertAction action)
-{
- if (m_webView->client()) {
- return m_webView->client()->shouldInsertText(WebString(text),
- WebRange(range),
- static_cast<WebEditingAction>(action));
- }
- return true;
-}
-
-
-bool EditorClientImpl::shouldDeleteRange(Range* range)
-{
- if (m_webView->client())
- return m_webView->client()->shouldDeleteRange(WebRange(range));
- return true;
-}
-
-bool EditorClientImpl::shouldChangeSelectedRange(Range* fromRange,
- Range* toRange,
- EAffinity affinity,
- bool stillSelecting)
-{
- if (m_webView->client()) {
- return m_webView->client()->shouldChangeSelectedRange(WebRange(fromRange),
- WebRange(toRange),
- static_cast<WebTextAffinity>(affinity),
- stillSelecting);
- }
- return true;
-}
-
-bool EditorClientImpl::shouldApplyStyle(StylePropertySet* style, Range* range)
-{
- if (m_webView->client()) {
- // FIXME: Pass a reference to the CSSStyleDeclaration somehow.
- return m_webView->client()->shouldApplyStyle(WebString(), WebRange(range));
- }
- return true;
-}
-
-void EditorClientImpl::didBeginEditing()
-{
- if (m_webView->client())
- m_webView->client()->didBeginEditing();
-}
-
void EditorClientImpl::respondToChangedSelection(Frame* frame)
{
if (m_webView->client() && frame)
@@ -251,12 +176,6 @@ void EditorClientImpl::respondToChangedContents()
m_webView->client()->didChangeContents();
}
-void EditorClientImpl::didEndEditing()
-{
- if (m_webView->client())
- m_webView->client()->didEndEditing();
-}
-
void EditorClientImpl::didCancelCompositionOnSelectionChange()
{
if (m_webView->client())
« no previous file with comments | « Source/web/EditorClientImpl.h ('k') | Source/web/WebFrameImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698