src/compiler/x64/instruction-scheduler-x64.cc - Issue 2623633003: [Atomics] Make Atomics.exchange a builtin using TF

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/x64/instruction-scheduler-x64.cc

Issue 2623633003: [Atomics] Make Atomics.exchange a builtin using TF (Closed)

Patch Set: fix win Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/x64/instruction-scheduler-x64.cc

diff --git a/src/compiler/x64/instruction-scheduler-x64.cc b/src/compiler/x64/instruction-scheduler-x64.cc

index 427e58083f6dd672ea6b9c259cc9a9eefbf2233c..30b6a68518871bd92cf549d3fc1931afdbaf43a0 100644

--- a/src/compiler/x64/instruction-scheduler-x64.cc

+++ b/src/compiler/x64/instruction-scheduler-x64.cc

@@ -178,11 +178,6 @@ int InstructionScheduler::GetTargetInstructionFlags(

case kX64Poke:

return kHasSideEffect;

- case kX64Xchgb:

- case kX64Xchgw:

- case kX64Xchgl:

- return kIsLoadOperation | kHasSideEffect;

#define CASE(Name) case k##Name:

COMMON_ARCH_OPCODE_LIST(CASE)

#undef CASE