src/compiler/x64/code-generator-x64.cc - Issue 2623633003: [Atomics] Make Atomics.exchange a builtin using TF

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/x64/code-generator-x64.cc

Issue 2623633003: [Atomics] Make Atomics.exchange a builtin using TF (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/x64/code-generator-x64.cc

diff --git a/src/compiler/x64/code-generator-x64.cc b/src/compiler/x64/code-generator-x64.cc

index 33e219e7ed6a519bdd060c18998315df9e16c941..0dd957988c8d56ef898f1c5a9f3484246b9540b6 100644

--- a/src/compiler/x64/code-generator-x64.cc

+++ b/src/compiler/x64/code-generator-x64.cc

@@ -2239,6 +2239,11 @@ CodeGenerator::CodeGenResult CodeGenerator::AssembleArchInstruction(

case kAtomicStoreWord8:

case kAtomicStoreWord16:

case kAtomicStoreWord32:

+ case kAtomicExchangeInt8:

+ case kAtomicExchangeUint8:

+ case kAtomicExchangeInt16:

+ case kAtomicExchangeUint16:

+ case kAtomicExchangeWord32:

UNREACHABLE(); // Won't be generated by instruction selector.

break;

}