[Atomics] Make Atomics.exchange a builtin using TF

src/builtins/builtins.h

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_BUILTINS_BUILTINS_H_
 #define V8_BUILTINS_BUILTINS_H_
 
 #include "src/base/flags.h"
 #include "src/globals.h"
 
@@ skipping 31 matching lines @@
 // TFJ: Builtin in Turbofan, with JS linkage (callable as Javascript function).
 //      Args: name, arguments count
 // TFS: Builtin in Turbofan, with CodeStub linkage.
 //      Args: name, code kind, extra IC state, interface descriptor, return_size
 // ASM: Builtin in platform-dependent assembly.
 //      Args: name
 // ASH: Handlers implemented in platform-dependent assembly.
 //      Args: name, code kind, extra IC state
 // DBG: Builtin in platform-dependent assembly, used by the debugger.
 //      Args: name
-#define BUILTIN_LIST(CPP, API, TFJ, TFS, ASM, ASH, DBG)                        \
+#if V8_TARGET_ARCH_MIPS || V8_TARGET_ARCH_MIPS64
+#define ATOMICS_BUILTIN_LIST(CPP, API, TFJ, TFS, ASM, ASH, DBG) \
+  CPP(AtomicsExchange)

[Jarin, 2017/03/01 07:45:37]

Rather than special casing here, could you keep the runtime function and let the
mips stub tailcall into the runtime function?

Even better, could you ping v8-mips-ports to help you with the mips part?

[aseemgarg, 2017/03/02 03:26:56]

Put in call to runtime function. Will ping v8-mips-ports once this patch is
submitted.

+#else
+#define ATOMICS_BUILTIN_LIST(CPP, API, TFJ, TFS, ASM, ASH, DBG) \
+  TFJ(AtomicsExchange, 3)
+#endif
+
+#define NON_ATOMICS_BUILTIN_LIST(CPP, API, TFJ, TFS, ASM, ASH, DBG)            \
   ASM(Abort)                                                                   \
   /* Code aging */                                                             \
   CODE_AGE_LIST_WITH_ARG(DECLARE_CODE_AGE_BUILTIN, ASM)                        \
                                                                                \
   /* Declared first for dependency reasons */                                  \
   ASM(CompileLazy)                                                             \
   TFS(ToObject, BUILTIN, kNoExtraICState, TypeConversion, 1)                   \
   TFS(FastNewObject, BUILTIN, kNoExtraICState, FastNewObject, 1)               \
   TFS(HasProperty, BUILTIN, kNoExtraICState, HasProperty, 1)                   \
                                                                                \
@@ skipping 777 matching lines @@
                                                                                \
   /* %AsyncFromSyncIteratorPrototype% */                                       \
   /* (proposal-async-iteration/#sec-%asyncfromsynciteratorprototype%-object)*/ \
   TFJ(AsyncFromSyncIteratorPrototypeNext, 1)                                   \
   TFJ(AsyncFromSyncIteratorPrototypeThrow, 1)                                  \
   TFJ(AsyncFromSyncIteratorPrototypeReturn, 1)                                 \
                                                                                \
   /* proposal-async-iteration/#sec-async-iterator-value-unwrap-functions */    \
   TFJ(AsyncIteratorValueUnwrap, 1)
 
+#define BUILTIN_LIST(CPP, API, TFJ, TFS, ASM, ASH, DBG)       \
+  NON_ATOMICS_BUILTIN_LIST(CPP, API, TFJ, TFS, ASM, ASH, DBG) \
+  ATOMICS_BUILTIN_LIST(CPP, API, TFJ, TFS, ASM, ASH, DBG)
+
 #define IGNORE_BUILTIN(...)
 
 #define BUILTIN_LIST_ALL(V) BUILTIN_LIST(V, V, V, V, V, V, V)
 
 #define BUILTIN_LIST_C(V)                                            \
   BUILTIN_LIST(V, V, IGNORE_BUILTIN, IGNORE_BUILTIN, IGNORE_BUILTIN, \
                IGNORE_BUILTIN, IGNORE_BUILTIN)
 
 #define BUILTIN_LIST_A(V)                                                      \
   BUILTIN_LIST(IGNORE_BUILTIN, IGNORE_BUILTIN, IGNORE_BUILTIN, IGNORE_BUILTIN, \
@@ skipping 133 matching lines @@
 
   friend class Isolate;
 
   DISALLOW_COPY_AND_ASSIGN(Builtins);
 };
 
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_BUILTINS_BUILTINS_H_