Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Side by Side Diff: third_party/WebKit/Source/core/frame/Frame.h

Issue 2623633002: Turn off requirement that cross-origin top navigation be accompanied by a user gesture. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999-2001 Lars Knoll <knoll@kde.org> 3 * 1999-2001 Lars Knoll <knoll@kde.org>
4 * 1999-2001 Antti Koivisto <koivisto@kde.org> 4 * 1999-2001 Antti Koivisto <koivisto@kde.org>
5 * 2000-2001 Simon Hausmann <hausmann@kde.org> 5 * 2000-2001 Simon Hausmann <hausmann@kde.org>
6 * 2000-2001 Dirk Mueller <mueller@kde.org> 6 * 2000-2001 Dirk Mueller <mueller@kde.org>
7 * 2000 Stefan Schimanski <1Stein@gmx.de> 7 * 2000 Stefan Schimanski <1Stein@gmx.de>
8 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights 8 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights
9 * reserved. 9 * reserved.
10 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies) 10 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
(...skipping 103 matching lines...) Expand 10 before | Expand all | Expand 10 after
114 114
115 Frame* findFrameForNavigation(const AtomicString& name, Frame& activeFrame); 115 Frame* findFrameForNavigation(const AtomicString& name, Frame& activeFrame);
116 Frame* findUnsafeParentScrollPropagationBoundary(); 116 Frame* findUnsafeParentScrollPropagationBoundary();
117 117
118 // This prepares the Frame for the next commit. It will detach children, 118 // This prepares the Frame for the next commit. It will detach children,
119 // dispatch unload events, abort XHR requests and detach the document. 119 // dispatch unload events, abort XHR requests and detach the document.
120 // Returns true if the frame is ready to receive the next commit, or false 120 // Returns true if the frame is ready to receive the next commit, or false
121 // otherwise. 121 // otherwise.
122 virtual bool prepareForCommit() = 0; 122 virtual bool prepareForCommit() = 0;
123 123
124 // TODO(japhet): These should all move to LocalFrame.
124 bool canNavigate(const Frame&); 125 bool canNavigate(const Frame&);
125 virtual void printNavigationErrorMessage(const Frame&, 126 virtual void printNavigationErrorMessage(const Frame&,
126 const char* reason) = 0; 127 const char* reason) = 0;
128 virtual void printNavigationWarning(const String&) = 0;
127 129
128 // TODO(pilgrim): Replace all instances of ownerLayoutObject() with 130 // TODO(pilgrim): Replace all instances of ownerLayoutObject() with
129 // ownerLayoutItem(), https://crbug.com/499321 131 // ownerLayoutItem(), https://crbug.com/499321
130 LayoutPart* ownerLayoutObject() 132 LayoutPart* ownerLayoutObject()
131 const; // LayoutObject for the element that contains this frame. 133 const; // LayoutObject for the element that contains this frame.
132 LayoutPartItem ownerLayoutItem() const; 134 LayoutPartItem ownerLayoutItem() const;
133 135
134 Settings* settings() const; // can be null 136 Settings* settings() const; // can be null
135 137
136 // isLoading() is true when the embedder should think a load is in progress. 138 // isLoading() is true when the embedder should think a load is in progress.
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
175 return m_treeNode; 177 return m_treeNode;
176 } 178 }
177 179
178 // Allow equality comparisons of Frames by reference or pointer, 180 // Allow equality comparisons of Frames by reference or pointer,
179 // interchangeably. 181 // interchangeably.
180 DEFINE_COMPARISON_OPERATORS_WITH_REFERENCES(Frame) 182 DEFINE_COMPARISON_OPERATORS_WITH_REFERENCES(Frame)
181 183
182 } // namespace blink 184 } // namespace blink
183 185
184 #endif // Frame_h 186 #endif // Frame_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698