Issue 262363002: Refresh Public Suffix List for the latest ICANN-contracted registries

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 262363002: Refresh Public Suffix List for the latest ICANN-contracted registries (Closed)

Created:
6 years, 7 months ago by Ryan Sleevi

Modified:
6 years, 7 months ago

Reviewers:
Peter Kasting

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Refresh Public Suffix List for the latest ICANN-contracted registries This updates to the following revision: ba86f988fb17 2014-03-10 08:57 -0400 It includes changes from revision ba86f988fb17 (2014-03-10 08:57 -0400) to revision e5572fc5c754 (2014-04-02 16:58 +0100), listed at http://hg.mozilla.org/mozilla-central/filelog/e5572fc5c754/netwerk/dns/effective_tld_names.dat BUG=37436 R=pkasting@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268376

Patch Set 1 #

Total comments: 1

Created: 6 years, 7 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+193 lines, -9 lines)			Patch
	M	net/base/registry_controlled_domains/effective_tld_names.dat	View		8 chunks	+146 lines, -6 lines	1 comment	Download
	M	net/base/registry_controlled_domains/effective_tld_names.gperf	View		44 chunks	+47 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ryan Sleevi

Peter: The last manual change for you to review, as hopefully olle's bits will land ...

6 years, 7 months ago (2014-05-06 01:50:48 UTC) #1

Peter Kasting

LGTM https://codereview.chromium.org/262363002/diff/1/net/base/registry_controlled_domains/effective_tld_names.dat File net/base/registry_controlled_domains/effective_tld_names.dat (left): https://codereview.chromium.org/262363002/diff/1/net/base/registry_controlled_domains/effective_tld_names.dat#oldcode1324 net/base/registry_controlled_domains/effective_tld_names.dat:1324: bergamo .it Wow, I'm surprised our tools didn't ...

6 years, 7 months ago (2014-05-06 01:57:42 UTC) #2

Ryan Sleevi

6 years, 7 months ago (2014-05-06 02:57:36 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r268376 (presubmit successful).

Expand Messages | Collapse Messages