Fix title and url animation for media in CCT

Fix title and url animation for media in CCT

This CL disables the title animation for media consumption in custom tabs.

BUG=650457

[shaktisahu, 2017-01-09 20:24:02]

shaktisahu@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[shaktisahu, 2017-01-09 20:24:11]

The CQ bit was checked by shaktisahu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-09 20:24:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-09 21:00:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-09 21:00:56]

Dry run: This issue passed the CQ dry run.

[gone, 2017-01-09 22:02:31]

dfalcantara@chromium.org changed reviewers:
+ ianwen@chromium.org

[gone, 2017-01-09 22:02:32]

Redirecting.

[Ian Wen, 2017-01-09 22:16:38]

The CustomTabToolbar runs like a state machine, and let's keep it stateful.

https://codereview.chromium.org/2623583002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
(right):

https://codereview.chromium.org/2623583002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java:1007:
((CustomTabToolbar) toolbar).setMediaViewer(true);
1. Concatenate this block with #1003. Only need to check isMediaViewer() once.
2. I believe there is no need to check toolbar instanceof CustomTabToolbar. It
is always the case.

https://codereview.chromium.org/2623583002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java
(right):

https://codereview.chromium.org/2623583002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java:392:
if (mMediaViewer) {
I still think that instead of having a media viewer boolean, we should have
another state called "STATE_DOMAIN_AND_TITLE_NO_ANIM". This class uses mState a
lot to track its internal state. Without such state control, it will easily fall
to craziness.

[shaktisahu, 2017-01-09 22:49:46]

https://codereview.chromium.org/2623583002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
(right):

https://codereview.chromium.org/2623583002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java:1007:
((CustomTabToolbar) toolbar).setMediaViewer(true);
On 2017/01/09 22:16:37, Ian Wen wrote:
> 1. Concatenate this block with #1003. Only need to check isMediaViewer() once.
> 2. I believe there is no need to check toolbar instanceof CustomTabToolbar. It
> is always the case.

Done.

https://codereview.chromium.org/2623583002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java
(right):

https://codereview.chromium.org/2623583002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java:392:
if (mMediaViewer) {
On 2017/01/09 22:16:37, Ian Wen wrote:
> I still think that instead of having a media viewer boolean, we should have
> another state called "STATE_DOMAIN_AND_TITLE_NO_ANIM". This class uses mState
a
> lot to track its internal state. Without such state control, it will easily
fall
> to craziness.

Done.

[Ian Wen, 2017-01-10 20:04:52]

https://codereview.chromium.org/2623583002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java
(right):

https://codereview.chromium.org/2623583002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java:401:
if (TextUtils.isEmpty(getCurrentTab().getTitle())) {
How can we guarantee that the urlbar will be shown when only the title is
updated later?

https://codereview.chromium.org/2623583002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java:514:
public void disableTitleAnimation() {
javadoc on public method. Besides, I would move this method above to #272

[shaktisahu, 2017-02-10 08:24:53]

On 2017/01/10 20:04:52, Ian Wen wrote:
>
https://codereview.chromium.org/2623583002/diff/20001/chrome/android/java/src...
> File
>
chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java
> (right):
> 
>
https://codereview.chromium.org/2623583002/diff/20001/chrome/android/java/src...
>
chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java:401:
> if (TextUtils.isEmpty(getCurrentTab().getTitle())) {
> How can we guarantee that the urlbar will be shown when only the title is
> updated later?
> 
>
https://codereview.chromium.org/2623583002/diff/20001/chrome/android/java/src...
>
chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java:514:
> public void disableTitleAnimation() {
> javadoc on public method. Besides, I would move this method above to #272

Closing this CL since this solution is not better than the current UI and this
is not a high priority at this moment.