src/objects/scope-info.h - Issue 2623573003: objects.h splitting: move ModuleInfo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects/scope-info.h

Issue 2623573003: objects.h splitting: move ModuleInfo (Closed)

Patch Set: more iwyu Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/objects/scope-info.h

diff --git a/src/objects/scope-info.h b/src/objects/scope-info.h

index e15894996031dce7894da53b78737326f065f6e2..0e1522bd72bb7b7ab63c7196631afc07b59dd0e2 100644

--- a/src/objects/scope-info.h

+++ b/src/objects/scope-info.h

@@ -8,9 +8,11 @@

#include "src/globals.h"

#include "src/handles.h"

#include "src/objects.h"

-#include "src/objects/object-macros.h"

#include "src/utils.h"

+// Has to be the last include:

Michael Starzinger 2017/01/10 15:26:24 nit: Maybe add "[...] because is doesn't have incl

marja 2017/01/10 15:36:36 Need to think of how to best explain this in 1 lin

+#include "src/objects/object-macros.h"

namespace v8 {

namespace internal {

« no previous file with comments | « src/objects/module-info.h ('k') | src/v8.gyp » ('j') | no next file with comments »