Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(766)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: trunk/src/build/mac/strip_save_dsym

Issue 26235007: Revert 227347 "Run strip via xcrun." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/build/mac/strip_save_dsym
===================================================================
--- trunk/src/build/mac/strip_save_dsym (revision 227523)
+++ trunk/src/build/mac/strip_save_dsym (working copy)
@@ -276,7 +276,13 @@
# Strip the Mach-O file
remove_dsym = True
try:
- strip_cmdline = ['xcrun', 'strip'] + sys.argv[1:]
+ strip_path = ""
+ if "SYSTEM_DEVELOPER_BIN_DIR" in os.environ:
+ strip_path = os.environ["SYSTEM_DEVELOPER_BIN_DIR"]
+ else:
+ strip_path = "/usr/bin"
+ strip_path = os.path.join(strip_path, "strip")
+ strip_cmdline = [strip_path] + sys.argv[1:]
strip_cmd = subprocess.Popen(strip_cmdline)
if strip_cmd.wait() == 0:
remove_dsym = False
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698