Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Unified Diff: src/builtins/builtins-handler.cc

Issue 2623483002: [cleanup] Port KeyedLoadIC_{Slow,Miss} to TF and drop unused IC handler code (Closed)
Patch Set: rebased Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/builtins/builtins.h ('k') | src/counters.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/builtins/builtins-handler.cc
diff --git a/src/builtins/builtins-handler.cc b/src/builtins/builtins-handler.cc
index c4b61850a744f99854a503ecd53bef08ef1271d9..d48e564255ffa38190a07d3ba49b0e5b0d7a9e5d 100644
--- a/src/builtins/builtins-handler.cc
+++ b/src/builtins/builtins-handler.cc
@@ -18,11 +18,32 @@ void Builtins::Generate_KeyedLoadIC_Megamorphic_TF(
AccessorAssembler::GenerateKeyedLoadICMegamorphic(state);
}
-void Builtins::Generate_KeyedLoadIC_Miss(MacroAssembler* masm) {
- KeyedLoadIC::GenerateMiss(masm);
+void Builtins::Generate_KeyedLoadIC_Miss(compiler::CodeAssemblerState* state) {
+ typedef compiler::Node Node;
+ typedef LoadWithVectorDescriptor Descriptor;
+ CodeStubAssembler assembler(state);
+
+ Node* receiver = assembler.Parameter(Descriptor::kReceiver);
+ Node* name = assembler.Parameter(Descriptor::kName);
+ Node* slot = assembler.Parameter(Descriptor::kSlot);
+ Node* vector = assembler.Parameter(Descriptor::kVector);
+ Node* context = assembler.Parameter(Descriptor::kContext);
+
+ assembler.TailCallRuntime(Runtime::kKeyedLoadIC_Miss, context, receiver, name,
+ slot, vector);
}
-void Builtins::Generate_KeyedLoadIC_Slow(MacroAssembler* masm) {
- KeyedLoadIC::GenerateRuntimeGetProperty(masm);
+
+void Builtins::Generate_KeyedLoadIC_Slow(compiler::CodeAssemblerState* state) {
+ typedef compiler::Node Node;
+ typedef LoadWithVectorDescriptor Descriptor;
+ CodeStubAssembler assembler(state);
+
+ Node* receiver = assembler.Parameter(Descriptor::kReceiver);
+ Node* name = assembler.Parameter(Descriptor::kName);
+ Node* context = assembler.Parameter(Descriptor::kContext);
+
+ assembler.TailCallRuntime(Runtime::kKeyedGetProperty, context, receiver,
+ name);
}
void Builtins::Generate_KeyedStoreIC_Megamorphic_TF(
« no previous file with comments | « src/builtins/builtins.h ('k') | src/counters.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698