Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(618)

Unified Diff: media/audio/audio_input_device.cc

Issue 2623443002: Fix getUserMedia so that failure is reported for invalid audio sources. (Closed)
Patch Set: Address comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/shell/renderer/layout_test/blink_test_runner.cc ('k') | media/audio/audio_input_device_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/audio/audio_input_device.cc
diff --git a/media/audio/audio_input_device.cc b/media/audio/audio_input_device.cc
index 9ebe4805ae010a2b514a95bc819bd47a9754e585..a6f93a3ab6f5117a11d8050859f4c6167419b6db 100644
--- a/media/audio/audio_input_device.cc
+++ b/media/audio/audio_input_device.cc
@@ -312,6 +312,12 @@ void AudioInputDevice::AudioThreadCallback::MapSharedMemory() {
audio_buses_.push_back(std::move(audio_bus));
ptr += segment_length_;
}
+
+ // Indicate that browser side capture initialization has succeeded and IPC
+ // channel initialized. This effectively completes the
+ // AudioCapturerSource::Start()' phase as far as the caller of that function
+ // is concerned.
+ capture_callback_->OnCaptureStarted();
}
void AudioInputDevice::AudioThreadCallback::Process(uint32_t pending_data) {
« no previous file with comments | « content/shell/renderer/layout_test/blink_test_runner.cc ('k') | media/audio/audio_input_device_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698