Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1458)

Unified Diff: content/renderer/media/webrtc/webrtc_media_stream_adapter_unittest.cc

Issue 2623443002: Fix getUserMedia so that failure is reported for invalid audio sources. (Closed)
Patch Set: Address comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/webrtc/webrtc_media_stream_adapter_unittest.cc
diff --git a/content/renderer/media/webrtc/webrtc_media_stream_adapter_unittest.cc b/content/renderer/media/webrtc/webrtc_media_stream_adapter_unittest.cc
index 01b27bc1460d45cdf274b2280ac62c1584f33eb9..d1d4b356970a2aab2b53a0ece0dcd8540255b782 100644
--- a/content/renderer/media/webrtc/webrtc_media_stream_adapter_unittest.cc
+++ b/content/renderer/media/webrtc/webrtc_media_stream_adapter_unittest.cc
@@ -58,10 +58,10 @@ class WebRtcMediaStreamAdapterTest : public ::testing::Test {
media::AudioParameters::kAudioCDSampleRate,
media::CHANNEL_LAYOUT_STEREO,
media::AudioParameters::kAudioCDSampleRate / 50),
+ MockConstraintFactory().CreateWebMediaConstraints(),
+ base::Bind(&WebRtcMediaStreamAdapterTest::OnAudioSourceStarted),
dependency_factory_.get());
source->SetAllowInvalidRenderFrameIdForTesting(true);
- source->SetSourceConstraints(
- MockConstraintFactory().CreateWebMediaConstraints());
audio_source.setExtraData(source); // Takes ownership.
audio_track_vector[0].initialize(audio_source);
EXPECT_CALL(*mock_audio_device_factory_.mock_capturer_source(),
@@ -119,6 +119,10 @@ class WebRtcMediaStreamAdapterTest : public ::testing::Test {
}
private:
+ static void OnAudioSourceStarted(MediaStreamSource* source,
+ MediaStreamRequestResult result,
+ const blink::WebString& result_name) {}
+
base::MessageLoop message_loop_;
std::unique_ptr<ChildProcess> child_process_;
std::unique_ptr<MockPeerConnectionDependencyFactory> dependency_factory_;

Powered by Google App Engine
This is Rietveld 408576698