chrome/renderer/media/cast_receiver_session_delegate.cc - Issue 2623443002: Fix getUserMedia so that failure is reported for invalid audio sources.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/media/cast_receiver_session_delegate.cc

Issue 2623443002: Fix getUserMedia so that failure is reported for invalid audio sources. (Closed)

Patch Set: Address comments Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/media/cast_receiver_session_delegate.cc

diff --git a/chrome/renderer/media/cast_receiver_session_delegate.cc b/chrome/renderer/media/cast_receiver_session_delegate.cc

index 790ed1742996ec10b93b3982b2fcfc8088e23579..2cfd6f82135ddd7f17120111fde121abb6f9e266 100644

--- a/chrome/renderer/media/cast_receiver_session_delegate.cc

+++ b/chrome/renderer/media/cast_receiver_session_delegate.cc

@@ -48,7 +48,8 @@ void CastReceiverSessionDelegate::ReceivePacket(

void CastReceiverSessionDelegate::StartAudio(

scoped_refptr<CastReceiverAudioValve> audio_valve) {

DCHECK(io_task_runner_->BelongsToCurrentThread());

- audio_valve_ = audio_valve;

+ audio_valve_ = std::move(audio_valve);

+ audio_valve_->OnStarted();

cast_receiver_->RequestDecodedAudioFrame(on_audio_decoded_cb_);

}