Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1139)

Side by Side Diff: media/base/audio_capturer_source.h

Issue 2623443002: Fix getUserMedia so that failure is reported for invalid audio sources. (Closed)
Patch Set: Address comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « media/audio/audio_input_device_unittest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef MEDIA_BASE_AUDIO_CAPTURER_SOURCE_H_ 5 #ifndef MEDIA_BASE_AUDIO_CAPTURER_SOURCE_H_
6 #define MEDIA_BASE_AUDIO_CAPTURER_SOURCE_H_ 6 #define MEDIA_BASE_AUDIO_CAPTURER_SOURCE_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 #include "base/memory/ref_counted.h" 10 #include "base/memory/ref_counted.h"
11 #include "media/base/audio_bus.h" 11 #include "media/base/audio_bus.h"
12 #include "media/base/audio_parameters.h" 12 #include "media/base/audio_parameters.h"
13 #include "media/base/media_export.h" 13 #include "media/base/media_export.h"
14 14
15 namespace media { 15 namespace media {
16 16
17 // AudioCapturerSource is an interface representing the source for 17 // AudioCapturerSource is an interface representing the source for
18 // captured audio. An implementation will periodically call Capture() on a 18 // captured audio. An implementation will periodically call Capture() on a
19 // callback object. 19 // callback object.
20 class AudioCapturerSource 20 class AudioCapturerSource
21 : public base::RefCountedThreadSafe<media::AudioCapturerSource> { 21 : public base::RefCountedThreadSafe<media::AudioCapturerSource> {
22 public: 22 public:
23 class CaptureCallback { 23 class CaptureCallback {
24 public: 24 public:
25 // Signals that audio recording has been started. Called asynchronously
26 // after Start() has completed. If Start() encounters problems before this
27 // callback can be made, OnCaptureError will be called instead.
28 virtual void OnCaptureStarted() = 0;
29
25 // Callback to deliver the captured data from the OS. 30 // Callback to deliver the captured data from the OS.
26 // TODO(chcunningham): Update delay argument to use frames instead of 31 // TODO(chcunningham): Update delay argument to use frames instead of
27 // milliseconds to prevent loss of precision. See http://crbug.com/587291. 32 // milliseconds to prevent loss of precision. See http://crbug.com/587291.
28 virtual void Capture(const AudioBus* audio_source, 33 virtual void Capture(const AudioBus* audio_source,
29 int audio_delay_milliseconds, 34 int audio_delay_milliseconds,
30 double volume, 35 double volume,
31 bool key_pressed) = 0; 36 bool key_pressed) = 0;
32 37
33 // Signals an error has occurred. 38 // Signals an error has occurred.
34 virtual void OnCaptureError(const std::string& message) = 0; 39 virtual void OnCaptureError(const std::string& message) = 0;
(...skipping 26 matching lines...) Expand all
61 virtual void SetAutomaticGainControl(bool enable) = 0; 66 virtual void SetAutomaticGainControl(bool enable) = 0;
62 67
63 protected: 68 protected:
64 friend class base::RefCountedThreadSafe<AudioCapturerSource>; 69 friend class base::RefCountedThreadSafe<AudioCapturerSource>;
65 virtual ~AudioCapturerSource() {} 70 virtual ~AudioCapturerSource() {}
66 }; 71 };
67 72
68 } // namespace media 73 } // namespace media
69 74
70 #endif // MEDIA_BASE_AUDIO_CAPTURER_SOURCE_H_ 75 #endif // MEDIA_BASE_AUDIO_CAPTURER_SOURCE_H_
OLDNEW
« no previous file with comments | « media/audio/audio_input_device_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698