Issue 2623423007: Support spawnUri in app snapshots.

Issue 2623423007: Support spawnUri in app snapshots. (Closed)

Created:
3 years, 11 months ago by rmacnak

Modified:
3 years, 11 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Support spawnUri in app snapshots. Don't mark core_isolate_snapshot_buffer as a const pointer. Fixes #28368 R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/c6ecfe1746137751e4b0fce9edcdf63a3aa93e12

Created: 3 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+88 lines, -93 lines)			Patch
M	runtime/bin/main.cc	View	12 chunks	+56 lines, -16 lines	0 comments	Download
M	runtime/bin/snapshot_empty.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/snapshot_in.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/lib/isolate.cc	View	1 chunk	+4 lines, -3 lines	0 comments	Download
M	runtime/observatory/tests/service/service.status	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/tests/vm/vm.status	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/benchmark_test.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/dart_api_impl_test.cc	View	5 chunks	+5 lines, -5 lines	0 comments	Download
M	runtime/vm/isolate_test.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/metrics_test.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/thread_test.cc	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	runtime/vm/unit_test.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/zone_test.cc	View	5 chunks	+5 lines, -5 lines	0 comments	Download
M	tests/co19/co19-runtime.status	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/isolate/isolate.status	View	1 chunk	+1 line, -1 line	0 comments	Download
M	utils/application_snapshot.gni	View	1 chunk	+0 lines, -45 lines	0 comments	Download
M	utils/pub/BUILD.gn	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (2 generated)

rmacnak

3 years, 11 months ago (2017-01-13 23:18:34 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c6ecfe1746137751e4b0fce9edcdf63a3aa93e12 (presubmit successful).