third_party/WebKit/LayoutTests/http/tests/security/cookies/resources/set-a-cookie.php - Issue 2623423002: Add console warning and tests for strict secure cookies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/security/cookies/resources/set-a-cookie.php

Issue 2623423002: Add console warning and tests for strict secure cookies.

Patch Set: Update comment Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/security/cookies/resources/get-cookie.html ('k') | third_party/WebKit/LayoutTests/http/tests/security/cookies/strict-secure-cookies.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/security/cookies/resources/set-a-cookie.php

diff --git a/third_party/WebKit/LayoutTests/http/tests/security/cookies/resources/set-a-cookie.php b/third_party/WebKit/LayoutTests/http/tests/security/cookies/resources/set-a-cookie.php

index 22121f188890c9ae075b97096341a1689a36edaf..ccf0690ca071c248aea6c5ac40616deeb2bb84c2 100644

--- a/third_party/WebKit/LayoutTests/http/tests/security/cookies/resources/set-a-cookie.php

+++ b/third_party/WebKit/LayoutTests/http/tests/security/cookies/resources/set-a-cookie.php

@@ -1,5 +1,17 @@

<?php

- setcookie("test_cookie", "1", 0, "/");

+ $secure = false;

+ if ($_GET["secure"]) {

+ $secure = true;

+ }

+ setcookie("test_cookie", "1", 0, "/", "", $secure);

+ $resetcookie = "true";

+ if ($_GET["resetcookie"] == "false")

+ $resetcookie = "false";

+ $notifydone = "true";

+ if ($_GET["notifydone"] == "false")

+ $notifydone = "false";

<!DOCTYPE html>

<html>

@@ -10,9 +22,13 @@ function checkCookie()

document.getElementById("log").innerHTML += "Cookie is NOT set";

else

document.getElementById("log").innerHTML += "Cookie is set";

- document.cookie = "test_cookie=0; path=/; expires=Thu, 01-Jan-1970 00:00:01 GMT";

- if (window.testRunner)

+ var reset_cookie = <?php echo($resetcookie); ?>;

+ if (reset_cookie)

+ document.cookie = "test_cookie=0; path=/; expires=Thu, 01-Jan-1970 00:00:01 GMT";

+ var notify_done = <?php echo $notifydone ?>;

+ if (notify_done && window.testRunner)

testRunner.notifyDone();

}

</script>