Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1243)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector/network/resources/set-cookie.php

Issue 2623423002: Add console warning and tests for strict secure cookies.
Patch Set: Update comment Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/inspector/network/warning-for-strict-secure-cookies.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/http/tests/inspector/network/resources/set-cookie.php
diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/network/resources/set-cookie.php b/third_party/WebKit/LayoutTests/http/tests/inspector/network/resources/set-cookie.php
index f4b870105ca201be87e5d0c0e11970618cf44cc1..67f197b049bf5545ea804a582015f488fe4ad1db 100644
--- a/third_party/WebKit/LayoutTests/http/tests/inspector/network/resources/set-cookie.php
+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/network/resources/set-cookie.php
@@ -4,14 +4,17 @@
header("Pragma: no-cache");
header("Content-Type: text/plain");
header("Access-Control-Allow-Origin: http://127.0.0.1:8000");
+ $secure = isset($_GET["secure"]);
$length = isset($_GET["length"]) ? (int) $_GET["length"] : 0;
if (!$length) {
- setcookie("TestCookie", "TestCookieValue");
+ setcookie("TestCookie", "TestCookieValue", 0, "", "", $secure);
} else {
$data = "";
for ($i = 0; $i < $length; $i++) {
$data .= "a";
}
+ if ($secure)
+ $data .= "; Secure";
header("Set-Cookie: $data");
}
echo("Cookie set.");
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/inspector/network/warning-for-strict-secure-cookies.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698