remoting/client/display/gl_renderer.h - Issue 2623413004: [Remoting Android] Fix thread issue with OpenGL drawable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/client/display/gl_renderer.h

Issue 2623413004: [Remoting Android] Fix thread issue with OpenGL drawable (Closed)

Patch Set: Reviewer's Feedback Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: remoting/client/display/gl_renderer.h

diff --git a/remoting/client/display/gl_renderer.h b/remoting/client/display/gl_renderer.h

index 72f04e4881474bccb7d6f06ee42c278e5d0882ed..46632187635b45bc3107cd8314c0bb52ad8836cd 100644

--- a/remoting/client/display/gl_renderer.h

+++ b/remoting/client/display/gl_renderer.h

@@ -98,6 +98,8 @@ class GlRenderer {

base::WeakPtr<GlRenderer> GetWeakPtr();

// Convenience method to create a Renderer with standard desktop components.

+ // This function must be called on the display thread, or whatever thread that

+ // will be used after the renderer is created.

static std::unique_ptr<GlRenderer> CreateGlRendererWithDesktop();

private:

« no previous file with comments | « no previous file | remoting/client/jni/jni_gl_display_handler.cc » ('j') | no next file with comments »