Consolidate subprocess retry logic into gclient_utils.

Consolidate subprocess retry logic into gclient_utils.

Add retry for all git operations that speak to a remote.  This
should smooth out issues with the git/gerrit-on-borg service.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=229219

[szager1, 2013-10-16 20:59:08]

ping

[M-A Ruel, 2013-10-17 01:37:25]

lgtm

https://codereview.chromium.org/26234004/diff/1/gclient_utils.py
File gclient_utils.py (right):

https://codereview.chromium.org/26234004/diff/1/gclient_utils.py#newcode486
gclient_utils.py:486: 'nap...' % (' '.join(['"%s"' % x for x in args]),
run_cwd))
' '.join('"%s"' % x for x in args)
or
' '.join(map(str, args))

as you prefer but the brackets are not necessary..

In practice, the str() is not necessary, if you are concerned about a caller
passing non str there, you can add an assert at the top of the function:
assert all(isinstance(x, str) for x in args), args

[szager1, 2013-10-17 18:34:20]

On 2013/10/17 01:37:25, M-A Ruel wrote:
> lgtm
> 
> https://codereview.chromium.org/26234004/diff/1/gclient_utils.py
> File gclient_utils.py (right):
> 
> https://codereview.chromium.org/26234004/diff/1/gclient_utils.py#newcode486
> gclient_utils.py:486: 'nap...' % (' '.join(['"%s"' % x for x in args]),
> run_cwd))
> ' '.join('"%s"' % x for x in args)
> or
> ' '.join(map(str, args))
> 
> as you prefer but the brackets are not necessary..
> 
> In practice, the str() is not necessary, if you are concerned about a caller
> passing non str there, you can add an assert at the top of the function:
> assert all(isinstance(x, str) for x in args), args

I just want all the arguments to be wrapped in double-quotes, to make it easier
to cut-and-paste them from the terminal output.

[M-A Ruel, 2013-10-17 18:44:11]

On 2013/10/17 18:34:20, szager1 wrote:
> I just want all the arguments to be wrapped in double-quotes, to make it
easier
> to cut-and-paste them from the terminal output.

Oh, I hadn't realized that. Just remove the [] then.

[szager1, 2013-10-17 19:20:46]

On 2013/10/17 18:44:11, M-A Ruel wrote:
> On 2013/10/17 18:34:20, szager1 wrote:
> > I just want all the arguments to be wrapped in double-quotes, to make it
> easier
> > to cut-and-paste them from the terminal output.
> 
> Oh, I hadn't realized that. Just remove the [] then.

Done.

[commit-bot: I haz the power, 2013-10-17 19:20:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/szager@chromium.org/26234004/13001

[commit-bot: I haz the power, 2013-10-17 19:22:40]

Presubmit check for 26234004-13001 failed and returned exit status 1.

Running presubmit commit checks ...
Checking out rietveld...
Running save-description-on-failure.sh
Running push-basic.sh
Running upstream.sh
Running submit-from-new-dir.sh
Running abandon.sh
Running submodule-merge-test.sh
Running upload-local-tracking-branch.sh
Running hooks.sh
Running post-dcommit-hook-test.sh
Running upload-stale.sh
Running patch.sh
Running basic.sh

** Presubmit ERRORS **
Pylint (66 files) failed
************* Module testing_support.gerrit_test_case
W0611: 44,0: Unused import httplib
W0611: 42,0: Unused import StringIO
W0611: 45,0: Unused import imp
W0611: 46,0: Unused import json
************* Module gclient_test
E1123:571,15: Passing unexpected keyword argument 'include_zero' in function
call
E1123:573,15: Passing unexpected keyword argument 'include_zero' in function
call
************* Module gclient_utils_test
R0201: 54,4:CheckCallAndFilterTestCase.ProcessIdMock.wait: Method could be a
function


tests/gclient_test.py failed
Traceback (most recent call last):
  File "tests/gclient_test.py", line 571, in <module>
    sys.stdout = gclient_utils.MakeFileAnnotated(sys.stdout, include_zero=True)
TypeError: MakeFileAnnotated() got an unexpected keyword argument 'include_zero'


Presubmit checks took 101.5s to calculate.

[commit-bot: I haz the power, 2013-10-17 19:40:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/szager@chromium.org/26234004/23001

[commit-bot: I haz the power, 2013-10-17 19:42:08]

Presubmit check for 26234004-23001 failed and returned exit status 1.

Running presubmit commit checks ...
Checking out rietveld...
Running save-description-on-failure.sh
Running push-basic.sh
Running upstream.sh
Running submit-from-new-dir.sh
Running abandon.sh
Running submodule-merge-test.sh
Running upload-local-tracking-branch.sh
Running hooks.sh
Running post-dcommit-hook-test.sh
Running upload-stale.sh
Running patch.sh
Running basic.sh

** Presubmit ERRORS **
Pylint (66 files) failed
************* Module testing_support.gerrit_test_case
W0611: 44,0: Unused import httplib
W0611: 42,0: Unused import StringIO
W0611: 45,0: Unused import imp
W0611: 46,0: Unused import json
************* Module gclient_utils_test
R0201: 54,4:CheckCallAndFilterTestCase.ProcessIdMock.wait: Method could be a
function


Presubmit checks took 112.3s to calculate.

[commit-bot: I haz the power, 2013-10-17 20:39:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/szager@chromium.org/26234004/26001

[commit-bot: I haz the power, 2013-10-17 20:41:44]

Change committed as 229219