Issue 26234003: Add *CSS* prefix to ShadowValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 26234003: Add CSS prefix to ShadowValue (Closed)

Created:
7 years, 2 months ago by gyuyoung-inactive

Modified:
7 years, 2 months ago

Reviewers:
tkent

CC:
blink-reviews, dglazkov+blink, apavlov+blink_chromium.org, darktears

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Add *CSS* prefix to ShadowValue To generate toCSSShadowValue(), this cl needs to add *CSS* prefix to ShadowValue. It is also to be consistent with existing other CSSFooValue naming style. BUG=N/A Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159076

Patch Set 1 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+39 lines, -195 lines)			Patch
M	Source/core/core.gypi	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/css/CSSComputedStyleDeclaration.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/css/CSSParser-in.cpp	View	3 chunks	+2 lines, -2 lines	0 comments	Download
A +	Source/core/css/CSSShadowValue.h	View	4 chunks	+9 lines, -7 lines	0 comments	Download
A +	Source/core/css/CSSShadowValue.cpp	View	3 chunks	+15 lines, -15 lines	0 comments	Download
M	Source/core/css/CSSValue.cpp	View	4 chunks	+4 lines, -4 lines	0 comments	Download
D	Source/core/css/ShadowValue.h	View	1 chunk	+0 lines, -67 lines	0 comments	Download
D	Source/core/css/ShadowValue.cpp	View	1 chunk	+0 lines, -91 lines	0 comments	Download
M	Source/core/css/resolver/FilterOperationResolver.cpp	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/core/css/resolver/StyleBuilderCustom.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/26234003/1

7 years, 2 months ago (2013-10-07 22:58:30 UTC) #3

Message was sent while issue was closed.

Change committed as 159076

Expand Messages | Collapse Messages

Issue 26234003: Add *CSS* prefix to ShadowValue (Closed)

Description

Patch Set 1 #

Messages

Issue 26234003: Add CSS prefix to ShadowValue (Closed)