Log states of JobController in Net MemoryDumpProvider

net/http/http_stream_factory_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/http/http_stream_factory_impl.h"
 
 #include <string>
 
 #include "base/logging.h"
 #include "base/memory/ptr_util.h"
 #include "base/metrics/histogram_macros.h"
 #include "base/stl_util.h"
 #include "base/strings/string_util.h"
+#include "base/strings/stringprintf.h"
+#include "base/trace_event/memory_allocator_dump.h"
+#include "base/trace_event/memory_usage_estimator.h"
+#include "base/trace_event/process_memory_dump.h"
 #include "net/http/http_network_session.h"
 #include "net/http/http_server_properties.h"
 #include "net/http/http_stream_factory_impl_job.h"
 #include "net/http/http_stream_factory_impl_job_controller.h"
 #include "net/http/http_stream_factory_impl_request.h"
 #include "net/http/transport_security_state.h"
 #include "net/proxy/proxy_info.h"
 #include "net/quic/core/quic_server_id.h"
 #include "net/spdy/bidirectional_stream_spdy_impl.h"
 #include "net/spdy/spdy_http_stream.h"
@@ skipping 271 matching lines @@
   HostPortPair host_port_pair = proxy_info.proxy_server().host_port_pair();
   DCHECK(!host_port_pair.IsEmpty());
 
   url::SchemeHostPort scheme_host_port("https", host_port_pair.host(),
                                        host_port_pair.port());
 
   return session_->http_server_properties()->SupportsRequestPriority(
       scheme_host_port);
 }
 
+void HttpStreamFactoryImpl::DumpMemoryStats(
+    base::trace_event::ProcessMemoryDump* pmd,
+    const std::string& parent_absolute_name) const {
+  std::string name =
+      base::StringPrintf("%s/stream_factory", parent_absolute_name.c_str());
+  base::trace_event::MemoryAllocatorDump* factory_dump =
+      pmd->CreateAllocatorDump(name);
+  size_t alt_job_count = 0;
+  size_t main_job_count = 0;
+  size_t preconnect_controller_count = 0;
+  for (const auto& it : job_controller_set_) {
+    if (it->HasPendingAltJob())
+      alt_job_count++;
+    if (it->HasPendingMainJob())
+      main_job_count++;

[Zhongyi Shi, 2017/01/18 20:39:32]

nit: preconnect jobcontrollers will only have main job, which means preconnect
controllers will be double counted. The current counting will work, it might be
better to determine whether the job controller is preconnect, and return early
so that when we count for pending main jobs, we don't double counting the
preconnect controllers. Both will work, I'll leave it to you to make the call.

[xunjieli, 2017/01/18 20:56:57]

Done.

+    if (it->is_preconnect())
+      preconnect_controller_count++;
+  }
+  factory_dump->AddScalar(
+      base::trace_event::MemoryAllocatorDump::kNameSize,
+      base::trace_event::MemoryAllocatorDump::kUnitsBytes,
+      base::trace_event::EstimateMemoryUsage(job_controller_set_));
+  factory_dump->AddScalar(
+      base::trace_event::MemoryAllocatorDump::kNameObjectCount,
+      base::trace_event::MemoryAllocatorDump::kUnitsObjects,
+      job_controller_set_.size());
+  factory_dump->AddScalar("alt_job_count",
+                          base::trace_event::MemoryAllocatorDump::kUnitsObjects,
+                          alt_job_count);
+  factory_dump->AddScalar("main_job_count",
+                          base::trace_event::MemoryAllocatorDump::kUnitsObjects,
+                          main_job_count);
+  factory_dump->AddScalar("preconnect_count",
+                          base::trace_event::MemoryAllocatorDump::kUnitsObjects,
+                          preconnect_controller_count);
+}
+
 }  // namespace net