Log states of JobController in Net MemoryDumpProvider

net/http/http_network_session.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/http/http_network_session.h"
 
 #include <utility>
 
 #include "base/atomic_sequence_num.h"
 #include "base/compiler_specific.h"
 #include "base/debug/stack_trace.h"
 #include "base/logging.h"
 #include "base/memory/memory_coordinator_client_registry.h"
 #include "base/memory/ptr_util.h"
 #include "base/profiler/scoped_tracker.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/trace_event/memory_allocator_dump.h"
+#include "base/trace_event/memory_dump_request_args.h"
 #include "base/trace_event/process_memory_dump.h"
 #include "base/values.h"
 #include "net/base/network_throttle_manager_impl.h"
 #include "net/http/http_auth_handler_factory.h"
 #include "net/http/http_response_body_drainer.h"
 #include "net/http/http_stream_factory_impl.h"
 #include "net/http/url_security_manager.h"
 #include "net/proxy/proxy_service.h"
 #include "net/quic/chromium/quic_crypto_client_stream_factory.h"
 #include "net/quic/chromium/quic_stream_factory.h"
@@ skipping 381 matching lines @@
   *proxy_config = *server_config;
   if (request.privacy_mode == PRIVACY_MODE_ENABLED) {
     server_config->channel_id_enabled = false;
   } else if (params_.enable_token_binding && params_.channel_id_service) {
     server_config->token_binding_params.push_back(TB_PARAM_ECDSAP256);
   }
 }
 
 void HttpNetworkSession::DumpMemoryStats(
     base::trace_event::ProcessMemoryDump* pmd,
+    const base::trace_event::MemoryDumpArgs& args,
     const std::string& parent_absolute_name) const {
   std::string name = base::StringPrintf("net/http_network_session_%p", this);
   base::trace_event::MemoryAllocatorDump* http_network_session_dump =
       pmd->GetAllocatorDump(name);
   if (http_network_session_dump == nullptr) {
     http_network_session_dump = pmd->CreateAllocatorDump(name);
     normal_socket_pool_manager_->DumpMemoryStats(
         pmd, http_network_session_dump->absolute_name());
     spdy_session_pool_.DumpMemoryStats(
         pmd, http_network_session_dump->absolute_name());
+    if (args.level_of_detail ==

[ssid, 2017/01/13 22:23:58]

I think your should call this always. Yes it adds an additional row. But this is
going to account for memory usage better.
Else we will miss tracking the size of stream factory in background mode.

[xunjieli, 2017/01/17 17:51:23]

Done.

+            base::trace_event::MemoryDumpLevelOfDetail::DETAILED &&
+        http_stream_factory_) {
+      http_stream_factory_->DumpMemoryStats(
+          pmd, http_network_session_dump->absolute_name());
+    }
   }
   // Create an empty row under parent's dump so size can be attributed correctly
   // if |this| is shared between URLRequestContexts.
   base::trace_event::MemoryAllocatorDump* empty_row_dump =
       pmd->CreateAllocatorDump(base::StringPrintf(
           "%s/http_network_session", parent_absolute_name.c_str()));
   pmd->AddOwnershipEdge(empty_row_dump->guid(),
                         http_network_session_dump->guid());
 }
 
@@ skipping 43 matching lines @@
       break;
     case base::MemoryState::SUSPENDED:
     // Note: Not supported at present. Fall through.
     case base::MemoryState::UNKNOWN:
       NOTREACHED();
       break;
   }
 }
 
 }  // namespace net