Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1281)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSharedPreferenceHelper.java

Issue 2623373002: [Download Home] More correctly track paused state (Closed)
Patch Set: Move observer [de]registration Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSharedPreferenceHelper.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSharedPreferenceHelper.java b/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSharedPreferenceHelper.java
index 668ee0175d631430fe57aee16f8224dad4169218..64cce559163a5fb730bcb15df1ad03d74dab1b9a 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSharedPreferenceHelper.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSharedPreferenceHelper.java
@@ -7,6 +7,7 @@ package org.chromium.chrome.browser.download;
import android.content.SharedPreferences;
import org.chromium.base.ContextUtils;
+import org.chromium.base.ObserverList;
import org.chromium.base.ThreadUtils;
import org.chromium.base.VisibleForTesting;
@@ -20,10 +21,18 @@ import java.util.Set;
* Class for maintaining all entries of DownloadSharedPreferenceEntry.
*/
public class DownloadSharedPreferenceHelper {
+ /** Observes modifications to the SharedPreferences for {@link DownloadItem}s. */
+ public interface Observer {
+ /** Called when a {@link DownloadSharedPreferenceEntry} has been updated. */
+ void onAddOrReplaceDownloadSharedPreferenceEntry(String guid);
+ }
+
@VisibleForTesting
static final String KEY_PENDING_DOWNLOAD_NOTIFICATIONS = "PendingDownloadNotifications";
private final List<DownloadSharedPreferenceEntry> mDownloadSharedPreferenceEntries =
new ArrayList<DownloadSharedPreferenceEntry>();
+ private final ObserverList<Observer> mObservers = new ObserverList<>();
+
private SharedPreferences mSharedPrefs;
// "Initialization on demand holder idiom"
@@ -64,6 +73,10 @@ public class DownloadSharedPreferenceHelper {
}
mDownloadSharedPreferenceEntries.add(pendingEntry);
storeDownloadSharedPreferenceEntries();
+
+ for (Observer observer : mObservers) {
+ observer.onAddOrReplaceDownloadSharedPreferenceEntry(pendingEntry.downloadGuid);
+ }
}
/**
@@ -130,6 +143,22 @@ public class DownloadSharedPreferenceHelper {
}
/**
+ * Adds the given {@link Observer}.
+ * @param observer Observer to notify about changes.
+ */
+ public void addObserver(Observer observer) {
+ mObservers.addObserver(observer);
+ }
+
+ /**
+ * Removes the given {@link Observer}.
+ * @param observer Observer to stop notifying about changes.
+ */
+ public void removeObserver(Observer observer) {
+ mObservers.removeObserver(observer);
+ }
+
+ /**
* Helper method to store all the SharedPreferences entries.
*/
private void storeDownloadSharedPreferenceEntries() {

Powered by Google App Engine
This is Rietveld 408576698