Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Issue 2623333005: Fix dispatch name of covariance-checked calls. (Closed)

Created:
3 years, 11 months ago by asgerf
Modified:
3 years, 11 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add test cases #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -2 lines) Patch
M pkg/kernel/lib/transformations/insert_covariance_checks.dart View 1 chunk +10 lines, -2 lines 0 comments Download
A tests/language_strong/covariant_subtyping_unsafe_call1_test.dart View 1 1 chunk +14 lines, -0 lines 0 comments Download
A tests/language_strong/covariant_subtyping_unsafe_call2_test.dart View 1 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
asgerf
3 years, 11 months ago (2017-01-13 16:36:26 UTC) #2
Kevin Millikin (Google)
LGTM.
3 years, 11 months ago (2017-01-16 11:15:35 UTC) #3
asgerf
3 years, 11 months ago (2017-01-16 11:43:48 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
2fc333c93de90adba16a159d5c8cdcc93e0564ce (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698