Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Unified Diff: src/builtins/builtins-promise.cc

Issue 2623313005: [inspector] introduced debug::SetAsyncTaskListener (Closed)
Patch Set: fixed compilation Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/builtins/builtins-promise.cc
diff --git a/src/builtins/builtins-promise.cc b/src/builtins/builtins-promise.cc
index c597999b00ffab16ca187061f7f2bfdd896b80fe..935da633a511b888780600707fbbfdc4b77c5da2 100644
--- a/src/builtins/builtins-promise.cc
+++ b/src/builtins/builtins-promise.cc
@@ -664,9 +664,6 @@ Node* PromiseBuiltinsAssembler::AllocatePromiseResolveThenableJobInfo(
PromiseResolveThenableJobInfo::kDebugIdOffset,
SmiConstant(kDebugPromiseNoID));
StoreObjectFieldNoWriteBarrier(
- info, PromiseResolveThenableJobInfo::kDebugNameOffset,
jgruber 2017/01/13 16:38:38 I'm confused, why does this Cl include promise-rel
kozy 2017/01/13 17:05:08 Done.
- SmiConstant(kDebugNotActive));
- StoreObjectFieldNoWriteBarrier(
info, PromiseResolveThenableJobInfo::kContextOffset, context);
return info;
}
@@ -796,12 +793,8 @@ void PromiseBuiltinsAssembler::InternalResolvePromise(Node* context,
Node* const debug_id =
CallRuntime(Runtime::kDebugNextAsyncTaskId, context, promise);
- Node* const debug_name = SmiConstant(kDebugPromiseResolveThenableJob);
-
StoreObjectField(info, PromiseResolveThenableJobInfo::kDebugIdOffset,
debug_id);
- StoreObjectField(info, PromiseResolveThenableJobInfo::kDebugNameOffset,
- debug_name);
GotoIf(TaggedIsSmi(result), &enqueue);
GotoUnless(HasInstanceType(result, JS_PROMISE_TYPE), &enqueue);

Powered by Google App Engine
This is Rietveld 408576698