Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: components/arc/intent_helper/arc_intent_helper_bridge_unittest.cc

Issue 2623273003: arc: Remove ArcServiceManager::Observer (Closed)
Patch Set: fix tests, review Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/arc/intent_helper/arc_intent_helper_bridge_unittest.cc
diff --git a/components/arc/intent_helper/arc_intent_helper_bridge_unittest.cc b/components/arc/intent_helper/arc_intent_helper_bridge_unittest.cc
index d849fe0b5193f8c04ced28b88961225f33653cf5..774f8b301ccf6190788be5c18cda39e4f979a899 100644
--- a/components/arc/intent_helper/arc_intent_helper_bridge_unittest.cc
+++ b/components/arc/intent_helper/arc_intent_helper_bridge_unittest.cc
@@ -8,6 +8,7 @@
#include "base/memory/ptr_util.h"
#include "components/arc/arc_bridge_service.h"
+#include "components/arc/arc_service_manager.h"
#include "components/arc/common/intent_helper.mojom.h"
#include "components/arc/intent_helper/activity_icon_loader.h"
#include "components/arc/intent_helper/local_activity_resolver.h"
@@ -165,4 +166,20 @@ TEST_F(ArcIntentHelperTest, TestObserver) {
EXPECT_FALSE(observer->IsUpdated());
}
+// Tests if the getter works as expected.
+TEST_F(ArcIntentHelperTest, TestGet) {
+ // The getter should return null when nullptr is passed in.
+ EXPECT_EQ(nullptr, ArcIntentHelperBridge::Get(nullptr));
+
+ // The getter should return null when the manager doesn't have an
+ // ArcIntentHelperBridge instance.
+ ArcServiceManager manager(nullptr);
+ EXPECT_EQ(nullptr, ArcIntentHelperBridge::Get(&manager));
+
+ // Register the instance and retry. The getter should return non-null this
+ // time.
+ manager.AddService(std::move(instance_));
+ EXPECT_NE(nullptr, ArcIntentHelperBridge::Get(&manager));
+}
+
} // namespace arc

Powered by Google App Engine
This is Rietveld 408576698