Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Side by Side Diff: content/public/app/BUILD.gn

Issue 2623143005: Only depend on child sources from app in both target (Closed)
Patch Set: . Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # App different than the regular content subcomponents (see comments in 5 # App different than the regular content subcomponents (see comments in
6 # //content/BUILD.gn) because it has to support the browser/child process split 6 # //content/BUILD.gn) because it has to support the browser/child process split
7 # (the "both" target include both browser and child process files and is used 7 # (the "both" target include both browser and child process files and is used
8 # for testing). 8 # for testing).
9 # 9 #
10 # In non-component mode, browser, child, and both all follow the same structure: 10 # In non-component mode, browser, child, and both all follow the same structure:
(...skipping 20 matching lines...) Expand all
31 "content_main_delegate.h", 31 "content_main_delegate.h",
32 "content_main_runner.h", 32 "content_main_runner.h",
33 "sandbox_helper_win.h", 33 "sandbox_helper_win.h",
34 ] 34 ]
35 35
36 public_app_shared_deps = [ 36 public_app_shared_deps = [
37 "//base", 37 "//base",
38 "//base:i18n", 38 "//base:i18n",
39 "//content:export", 39 "//content:export",
40 "//content/public/common:common_sources", 40 "//content/public/common:common_sources",
41 "//content/public/gpu:gpu_sources",
42 "//content/public/renderer:renderer_sources",
43 "//content/public/utility:utility_sources",
44 ] 41 ]
45 42
46 if (use_aura) { 43 if (use_aura) {
47 public_app_shared_deps += [ "//ui/aura" ] 44 public_app_shared_deps += [ "//ui/aura" ]
48 } 45 }
49 46
50 if (is_component_build) { 47 if (is_component_build) {
51 source_set("both_sources") { 48 source_set("both_sources") {
52 # Only the main content shared library can pull this in. 49 # Only the main content shared library can pull this in.
53 visibility = [ "//content:content" ] 50 visibility = [ "//content:content" ]
54 51
55 sources = public_app_shared_sources 52 sources = public_app_shared_sources
56 53
57 configs += [ "//content:content_implementation" ] 54 configs += [ "//content:content_implementation" ]
58 55
59 deps = public_app_shared_deps + [ 56 deps = public_app_shared_deps + [
60 "//content/app:both", 57 "//content/app:both",
61 "//content/public/browser:browser_sources", 58 "//content/public/browser:browser_sources",
59 "//content/public/gpu:gpu_sources",
60 "//content/public/renderer:renderer_sources",
61 "//content/public/utility:utility_sources",
62 ] 62 ]
63 63
64 allow_circular_includes_from = [ 64 allow_circular_includes_from = [
65 # This target is a pair with the non-public version. They always go 65 # This target is a pair with the non-public version. They always go
66 # together and include headers from each other. 66 # together and include headers from each other.
67 "//content/app:both", 67 "//content/app:both",
68 ] 68 ]
69 } 69 }
70 70
71 # These all just forward to content, which in turn depends on "both_sources". 71 # These all just forward to content, which in turn depends on "both_sources".
(...skipping 26 matching lines...) Expand all
98 98
99 source_set("both") { 99 source_set("both") {
100 check_includes = false # See comment above. 100 check_includes = false # See comment above.
101 101
102 sources = public_app_shared_sources 102 sources = public_app_shared_sources
103 configs += [ "//content:content_implementation" ] 103 configs += [ "//content:content_implementation" ]
104 deps = public_app_shared_deps + [ 104 deps = public_app_shared_deps + [
105 "//content/app:both", 105 "//content/app:both",
106 "//content/public/browser", 106 "//content/public/browser",
107 "//content/public/common", 107 "//content/public/common",
108 "//content/public/gpu:gpu_sources",
109 "//content/public/renderer:renderer_sources",
110 "//content/public/utility:utility_sources",
108 ] 111 ]
109 112
110 allow_circular_includes_from = [ 113 allow_circular_includes_from = [
111 # This target is a pair with the non-public version. They always go 114 # This target is a pair with the non-public version. They always go
112 # together and include headers from each other. 115 # together and include headers from each other.
113 "//content/app:both", 116 "//content/app:both",
114 ] 117 ]
115 } 118 }
116 119
117 if (is_multi_dll_chrome) { 120 if (is_multi_dll_chrome) {
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
198 201
199 service_manifest("renderer_manifest") { 202 service_manifest("renderer_manifest") {
200 name = "content_renderer" 203 name = "content_renderer"
201 source = "mojo/content_renderer_manifest.json" 204 source = "mojo/content_renderer_manifest.json"
202 } 205 }
203 206
204 service_manifest("utility_manifest") { 207 service_manifest("utility_manifest") {
205 name = "content_utility" 208 name = "content_utility"
206 source = "mojo/content_utility_manifest.json" 209 source = "mojo/content_utility_manifest.json"
207 } 210 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698