DevTools: insert console message decorations in order

third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js

Index: third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js b/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
index e435228680f86067dc7938fe70f8fe0855754dd6..c5673f74aeb11adbe1ea8fc07ea792c1c3fa44ce 100644
--- a/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
+++ b/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
@@ -121,7 +121,7 @@ Console.ConsoleView = class extends UI.VBox {
 
     this._viewportThrottler = new Common.Throttler(50);
 
-    this._filterStatusMessageElement = createElementWithClass('div', 'console-message');
+    this._filterStatusMessageElement = createElementWithClass('div', 'console-message-wrapper');
     this._messagesElement.insertBefore(this._filterStatusMessageElement, this._messagesElement.firstChild);
     this._filterStatusTextElement = this._filterStatusMessageElement.createChild('span', 'console-info');
     this._filterStatusMessageElement.createTextChild(' ');
@@ -163,7 +163,7 @@ Console.ConsoleView = class extends UI.VBox {
     this._consoleHistoryAutocompleteChanged();
 
     this._updateFilterStatus();
-    this._timestampsSetting.addChangeListener(this._consoleTimestampsSettingChanged, this);
+    this._timestampsSetting.addChangeListener(this._updateMessageList, this);
 
     this._registerWithMessageSink();
     SDK.targetManager.observeTargets(this);
@@ -333,11 +333,6 @@ Console.ConsoleView = class extends UI.VBox {
     this._addConsoleMessage(consoleMessage);
   }
 
-  _consoleTimestampsSettingChanged() {
-    this._updateMessageList();
-    this._consoleMessages.forEach(viewMessage => viewMessage.updateTimestamp());
-  }
-
   _executionContextChanged() {
     this._prompt.clearAutocomplete();
     if (this._filter._showTargetMessagesCheckbox.checked())
@@ -559,8 +554,6 @@ Console.ConsoleView = class extends UI.VBox {
     switch (message.type) {
       case SDK.ConsoleMessage.MessageType.Command:
         return new Console.ConsoleCommand(message, this._linkifier, nestingLevel);
-      case SDK.ConsoleMessage.MessageType.Result:
-        return new Console.ConsoleCommandResult(message, this._linkifier, nestingLevel);
       case SDK.ConsoleMessage.MessageType.StartGroupCollapsed:
       case SDK.ConsoleMessage.MessageType.StartGroup:
         return new Console.ConsoleGroupViewMessage(message, this._linkifier, nestingLevel);
@@ -714,6 +707,7 @@ Console.ConsoleView = class extends UI.VBox {
     this._updateFilterStatus();
     this._searchableView.updateSearchMatchesCount(this._regexMatchRanges.length);
     this._viewport.invalidate();
+    this._visibleViewMessages.forEach(message => message.updateMessageElement());

[pfeldman, 2017/02/22 00:10:45]

This still does not make much sense to me! Why do we invalidate and also rebuild
all the messages in one call?

   }
 
   /**
@@ -1197,9 +1191,6 @@ Console.ConsoleCommand = class extends Console.ConsoleViewMessage {
   contentElement() {
     if (!this._contentElement) {
       this._contentElement = createElementWithClass('div', 'console-user-command');
-      var icon = UI.Icon.create('smallicon-user-command', 'command-result-icon');
-      this._contentElement.appendChild(icon);
-
       this._contentElement.message = this;
 
       this._formattedCommand = createElementWithClass('span', 'source-code');
@@ -1212,8 +1203,6 @@ Console.ConsoleCommand = class extends Console.ConsoleViewMessage {
       } else {
         this._updateSearch();
       }
-
-      this.updateTimestamp();
     }
     return this._contentElement;
   }
@@ -1233,36 +1222,6 @@ Console.ConsoleCommand.MaxLengthToIgnoreHighlighter = 10000;
 /**
  * @unrestricted
  */
-Console.ConsoleCommandResult = class extends Console.ConsoleViewMessage {
-  /**
-   * @param {!SDK.ConsoleMessage} message
-   * @param {!Components.Linkifier} linkifier
-   * @param {number} nestingLevel
-   */
-  constructor(message, linkifier, nestingLevel) {
-    super(message, linkifier, nestingLevel);
-  }
-
-  /**
-   * @override
-   * @return {!Element}
-   */
-  contentElement() {
-    var element = super.contentElement();
-    if (!element.classList.contains('console-user-command-result')) {
-      element.classList.add('console-user-command-result');
-      if (this.consoleMessage().level === SDK.ConsoleMessage.MessageLevel.Info) {
-        var icon = UI.Icon.create('smallicon-command-result', 'command-result-icon');
-        element.insertBefore(icon, element.firstChild);
-      }
-    }
-    return element;
-  }
-};
-
-/**
- * @unrestricted
- */
 Console.ConsoleGroup = class {
   /**
    * @param {?Console.ConsoleGroup} parentGroup