third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js - Issue 2623143002: DevTools: insert console message decorations in order

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js

Issue 2623143002: DevTools: insert console message decorations in order

Patch Set: address design comments Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/console/ConsoleContextSelector.js ('K') | « third_party/WebKit/Source/devtools/front_end/console/ConsoleContextSelector.js ('k') | third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js » ('j') | third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js b/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js

index 87c0470fd53622c3f91b73d47378b209e67cb58a..9130f1dbc90af18be8aac912f884954ca909648f 100644

--- a/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js

+++ b/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js

@@ -334,6 +334,9 @@ Console.ConsoleView = class extends UI.VBox {

this._prompt.clearAutocomplete();

if (!this._showAllMessagesCheckbox.checked())

this._updateMessageList();

+ this._consoleMessages.map(message => {

allada 2017/01/19 02:38:08 Don't use map, use .forEach()

allada 2017/01/19 02:38:08 nit: Remove curlies and put on same line.

luoe 2017/01/19 23:22:59 Done.

+ message.updateContextLabel();

+ });

}

/**