Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/sources/ThreadsSidebarPane.js

Issue 2623143002: DevTools: insert console message decorations in order
Patch Set: address design comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 /** 4 /**
5 * @implements {SDK.TargetManager.Observer} 5 * @implements {SDK.TargetManager.Observer}
6 * @unrestricted 6 * @unrestricted
7 */ 7 */
8 Sources.ThreadsSidebarPane = class extends UI.VBox { 8 Sources.ThreadsSidebarPane = class extends UI.VBox {
9 constructor() { 9 constructor() {
10 super(); 10 super();
(...skipping 174 matching lines...) Expand 10 before | Expand all | Expand 10 after
185 185
186 /** 186 /**
187 * @param {!SDK.PendingTarget} pendingTarget 187 * @param {!SDK.PendingTarget} pendingTarget
188 * @return {string} 188 * @return {string}
189 */ 189 */
190 _titleForPending(pendingTarget) { 190 _titleForPending(pendingTarget) {
191 var target = pendingTarget.target(); 191 var target = pendingTarget.target();
192 if (!target) 192 if (!target)
193 return pendingTarget.name(); 193 return pendingTarget.name();
194 var executionContext = target.runtimeModel.defaultExecutionContext(); 194 var executionContext = target.runtimeModel.defaultExecutionContext();
195 return executionContext && executionContext.label() ? executionContext.label () : target.name(); 195 var label = executionContext ? executionContext.label(true /* showStatus */) : null;
196 return label || target.name();
196 } 197 }
197 198
198 /** 199 /**
199 * @param {!Common.Event} event 200 * @param {!Common.Event} event
200 */ 201 */
201 _onDebuggerStateChanged(event) { 202 _onDebuggerStateChanged(event) {
202 var debuggerModel = /** @type {!SDK.DebuggerModel} */ (event.data); 203 var debuggerModel = /** @type {!SDK.DebuggerModel} */ (event.data);
203 var pendingTarget = this._targetToPending.get(debuggerModel.target()); 204 var pendingTarget = this._targetToPending.get(debuggerModel.target());
204 this._updateDebuggerState(pendingTarget); 205 this._updateDebuggerState(pendingTarget);
205 } 206 }
206 207
207 /** 208 /**
208 * @param {!Common.Event} event 209 * @param {!Common.Event} event
209 */ 210 */
210 _onExecutionContextChanged(event) { 211 _onExecutionContextChanged(event) {
211 var executionContext = /** @type {!SDK.ExecutionContext} */ (event.data); 212 var executionContext = /** @type {!SDK.ExecutionContext} */ (event.data);
212 if (!executionContext.isDefault) 213 if (!executionContext.isDefault)
213 return; 214 return;
214 var pendingTarget = this._targetToPending.get(executionContext.target()); 215 var pendingTarget = this._targetToPending.get(executionContext.target());
215 var listItem = this._pendingToListItem.get(pendingTarget); 216 var listItem = this._pendingToListItem.get(pendingTarget);
216 if (listItem && executionContext.label()) 217 if (listItem && executionContext.label(true /* showStatus */))
217 listItem.setTitle(executionContext.label()); 218 listItem.setTitle(executionContext.label(true /* showStatus */));
218 } 219 }
219 220
220 /** 221 /**
221 * @param {!SDK.PendingTarget} pendingTarget 222 * @param {!SDK.PendingTarget} pendingTarget
222 */ 223 */
223 _updateDebuggerState(pendingTarget) { 224 _updateDebuggerState(pendingTarget) {
224 var listItem = this._pendingToListItem.get(pendingTarget); 225 var listItem = this._pendingToListItem.get(pendingTarget);
225 var target = pendingTarget.target(); 226 var target = pendingTarget.target();
226 var debuggerModel = target && SDK.DebuggerModel.fromTarget(target); 227 var debuggerModel = target && SDK.DebuggerModel.fromTarget(target);
227 var isPaused = !!debuggerModel && debuggerModel.isPaused(); 228 var isPaused = !!debuggerModel && debuggerModel.isPaused();
(...skipping 115 matching lines...) Expand 10 before | Expand all | Expand 10 after
343 } 344 }
344 345
345 /** 346 /**
346 * @override 347 * @override
347 * @return {string} 348 * @return {string}
348 */ 349 */
349 name() { 350 name() {
350 return this._target.name(); 351 return this._target.name();
351 } 352 }
352 }; 353 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698