Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js

Issue 2623143002: DevTools: insert console message decorations in order
Patch Set: address design comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
3 * Copyright (C) 2009 Joseph Pecoraro 3 * Copyright (C) 2009 Joseph Pecoraro
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 8 *
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 316 matching lines...) Expand 10 before | Expand all | Expand 10 after
327 this._updateMessageList(); 327 this._updateMessageList();
328 this._consoleMessages.forEach(function(viewMessage) { 328 this._consoleMessages.forEach(function(viewMessage) {
329 viewMessage.updateTimestamp(enabled); 329 viewMessage.updateTimestamp(enabled);
330 }); 330 });
331 } 331 }
332 332
333 _executionContextChanged() { 333 _executionContextChanged() {
334 this._prompt.clearAutocomplete(); 334 this._prompt.clearAutocomplete();
335 if (!this._showAllMessagesCheckbox.checked()) 335 if (!this._showAllMessagesCheckbox.checked())
336 this._updateMessageList(); 336 this._updateMessageList();
337 this._consoleMessages.map(message => {
allada 2017/01/19 02:38:08 Don't use map, use .forEach()
allada 2017/01/19 02:38:08 nit: Remove curlies and put on same line.
luoe 2017/01/19 23:22:59 Done.
luoe 2017/01/19 23:22:59 Done.
338 message.updateContextLabel();
339 });
337 } 340 }
338 341
339 /** 342 /**
340 * @override 343 * @override
341 */ 344 */
342 willHide() { 345 willHide() {
343 this._hidePromptSuggestBox(); 346 this._hidePromptSuggestBox();
344 } 347 }
345 348
346 /** 349 /**
(...skipping 987 matching lines...) Expand 10 before | Expand all | Expand 10 after
1334 return true; 1337 return true;
1335 } 1338 }
1336 return false; 1339 return false;
1337 } 1340 }
1338 }; 1341 };
1339 1342
1340 /** 1343 /**
1341 * @typedef {{messageIndex: number, matchIndex: number}} 1344 * @typedef {{messageIndex: number, matchIndex: number}}
1342 */ 1345 */
1343 Console.ConsoleView.RegexMatchRange; 1346 Console.ConsoleView.RegexMatchRange;
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698