Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 2623113004: VM: Make indirect subclasses of StackResource have virtual destructor (Closed)

Created:
3 years, 11 months ago by kustermann
Modified:
3 years, 11 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM: Make indirect subclasses of StackResource have virtual destructor R=vegorov@google.com Committed: https://github.com/dart-lang/sdk/commit/2b5352890f366827861a6ad5bbc16f9679855644

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M runtime/vm/timeline.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
kustermann
3 years, 11 months ago (2017-01-12 11:46:19 UTC) #2
Vyacheslav Egorov (Google)
LGTM
3 years, 11 months ago (2017-01-12 11:52:58 UTC) #3
kustermann
3 years, 11 months ago (2017-01-12 11:53:50 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2b5352890f366827861a6ad5bbc16f9679855644 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698