Add logs to XMLHttpRequest to ease debugging.

Add logs to XMLHttpRequest to ease debugging.

In debugging complicated XHR bugs, it's important to understand sequence
of method calls and state transition. I want to upstream simple logs at the
head of each method implementations and loader delegate methods I'm regularly
putting for debugging.

BUG=

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159234

[yhirano, 2013-10-07 09:51:27]

lgtm

All comments are optional.

https://codereview.chromium.org/26231002/diff/12001/Source/core/xml/XMLHttpRe...
File Source/core/xml/XMLHttpRequest.cpp (right):

https://codereview.chromium.org/26231002/diff/12001/Source/core/xml/XMLHttpRe...
Source/core/xml/XMLHttpRequest.cpp:1179: LOG(Network, "XMLHttpRequest %p
didFinishLoading()", this);
Printing identifier may be helpful.

https://codereview.chromium.org/26231002/diff/12001/Source/core/xml/XMLHttpRe...
Source/core/xml/XMLHttpRequest.cpp:1227: LOG(Network, "XMLHttpRequest %p
didReceiveResponse()", this);
Printing identifier may be helpful.

https://codereview.chromium.org/26231002/diff/12001/Source/core/xml/XMLHttpRe...
Source/core/xml/XMLHttpRequest.cpp:1241: void
XMLHttpRequest::didReceiveData(const char* data, int len)
Should we have a log message here?

[tyoshino (SeeGerritForStatus), 2013-10-08 13:09:11]

https://codereview.chromium.org/26231002/diff/12001/Source/core/xml/XMLHttpRe...
File Source/core/xml/XMLHttpRequest.cpp (right):

https://codereview.chromium.org/26231002/diff/12001/Source/core/xml/XMLHttpRe...
Source/core/xml/XMLHttpRequest.cpp:1179: LOG(Network, "XMLHttpRequest %p
didFinishLoading()", this);
On 2013/10/07 09:51:27, yhirano wrote:
> Printing identifier may be helpful.

Done.

https://codereview.chromium.org/26231002/diff/12001/Source/core/xml/XMLHttpRe...
Source/core/xml/XMLHttpRequest.cpp:1227: LOG(Network, "XMLHttpRequest %p
didReceiveResponse()", this);
On 2013/10/07 09:51:27, yhirano wrote:
> Printing identifier may be helpful.

Done.

https://codereview.chromium.org/26231002/diff/12001/Source/core/xml/XMLHttpRe...
Source/core/xml/XMLHttpRequest.cpp:1241: void
XMLHttpRequest::didReceiveData(const char* data, int len)
On 2013/10/07 09:51:27, yhirano wrote:
> Should we have a log message here?

Skipped since having a LOG here makes XHR too verbose.

[tyoshino (SeeGerritForStatus), 2013-10-08 13:14:14]

Hi japhet,

Could you please review this?

[Nate Chapin, 2013-10-08 16:23:21]

lgtm

[commit-bot: I haz the power, 2013-10-09 03:11:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tyoshino@chromium.org/26231002/22001

[commit-bot: I haz the power, 2013-10-09 05:26:23]

Sorry for I got bad news for ya.
Compile failed with a clobber build on mac_layout.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[tyoshino (SeeGerritForStatus), 2013-10-09 12:49:11]

Fixed. Use %llu for unsigned long long.

[commit-bot: I haz the power, 2013-10-09 12:49:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tyoshino@chromium.org/26231002/36001

[commit-bot: I haz the power, 2013-10-09 14:49:45]

Change committed as 159234