Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(602)

Issue 2623073003: Change from "CompileTimeError" to "Fail". (Closed)

Created:
3 years, 11 months ago by floitsch
Modified:
3 years, 11 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Change from "CompileTimeError" to "Fail". Dartium treats compile time errors as runtime errors. "Fail" covers both. Committed: https://github.com/dart-lang/sdk/commit/bfb5ee07b6267ff5530336ffa227c71495d9779d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tests/language/language.status View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
floitsch
TBR.
3 years, 11 months ago (2017-01-11 18:49:09 UTC) #2
floitsch
Committed patchset #1 (id:1) manually as bfb5ee07b6267ff5530336ffa227c71495d9779d (presubmit successful).
3 years, 11 months ago (2017-01-11 18:49:20 UTC) #4
Siggi Cherem (dart-lang)
3 years, 11 months ago (2017-01-11 18:54:11 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698